12 Jun
2023
12 Jun
'23
4:13 p.m.
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 2a09f35ba76392ce6e29c0c17c253398619f12de
https://github.com/Checkmk/checkmk/commit/2a09f35ba76392ce6e29c0c17c2533986…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15894
M cmk/base/plugins/agent_based/domino_tasks.py
M cmk/base/plugins/agent_based/ps_check.py
M cmk/base/plugins/agent_based/ps_section.py
M cmk/base/plugins/agent_based/utils/ps.py
M tests/unit/cmk/base/plugins/agent_based/test_domino_tasks.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_check.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
M tests/unit/cmk/base/plugins/agent_based/utils/test_ps.py
Log Message:
-----------
FIX: State and Count of Processes: Calculate process creation time consistently
The creation time of a process, as displayed by the "State and Count of
Processes" service is calculated by taking the difference between the current time
and the time elapsed since the process was started.
Previously, this used the time the check was performed at as the current time, leading to
different creation times if different services were created for the same process.
Now the time the agent section was parsed is used instead.
Note that this will still lead to incorrect creation times if it takes too long to fetch
the agent output.
SUP-14394
Change-Id: If282dc8258395a69a67344b448fdfec86d0c2f6f
Commit: 740a2d367c0314d182588accf2327f76f0f0b478
https://github.com/Checkmk/checkmk/commit/740a2d367c0314d182588accf2327f76f…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15895
M agents/check_mk_agent.linux
M cmk/base/plugins/agent_based/ps_section.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
Log Message:
-----------
FIX: State and Count of Processes: Use remote server time for process creation time when
using Linux agent
As mentioned in werk 15894, the reference time used to calculate the creation time of a
process as displayed by the "State and Count of Processes" service is the time
the agent section was parsed.
The <tt>check_mk_agent.linux</tt> agent will now also output the time at which
the ps command was executed to be used as a reference instead.
The agent must be redeployed to take advantage of this change.
SUP-14394
Change-Id: Iac7c9b59d01a9b5dc5d46ca501d849d6fa84e463
Commit: 5ab7d42e318d5b91de67be746439b8a9fc16fa73
https://github.com/Checkmk/checkmk/commit/5ab7d42e318d5b91de67be746439b8a9f…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
A .werks/15896
M agents/check_mk_agent.aix
M agents/check_mk_agent.solaris
M cmk/base/plugins/agent_based/ps_section.py
M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py
Log Message:
-----------
15896 FIX State and Count of Processes: Use remote server time for process creation time
when using Solaris or AIX agent
As mentioned in werk 15894, the reference time used to calculate the creation time of a
process as displayed by the "State and Count of Processes" service is the time
the agent section was parsed.
The <tt>check_mk_agent.solaris</tt> and
<tt>check_mk_agent.aix</tt> agents will now also output the time at which the
ps command was executed to be used as reference instead.
The agent must be redeployed to take advantage of this change.
SUP-14394
Change-Id: I734ef73b6707310543b7e8bc65160a095742d867
Commit: 6109a94cc696fda6f6e823068efb65f322675fd6
https://github.com/Checkmk/checkmk/commit/6109a94cc696fda6f6e823068efb65f32…
Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M .werks/15896
M agents/check_mk_agent.freebsd
M agents/check_mk_agent.macosx
M agents/check_mk_agent.netbsd
M agents/check_mk_agent.openbsd
M agents/check_mk_agent.openwrt
Log Message:
-----------
State and Count of Processes: Add remote server time for more agents
Output the time at which the ps-command was executed for freebsd, macosx, netbsd, openbsd
and openwrt agents
SUP-14394
Change-Id: Iea08e2e61e79f4b82bbd68ada7520767fe7a52de
Commit: 04f1e33c1db61e286b6229173219c6c7162cfd67
https://github.com/Checkmk/checkmk/commit/04f1e33c1db61e286b6229173219c6c71…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/plugins/openapi/endpoints/ruleset/__init__.py
M cmk/gui/wato/pages/predefined_conditions.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
ruleset: Inline useless `filter` static method
CMK-13680
Change-Id: I515e8b1b5e748668822935be53ad1f599e64a58b
Commit: 504d550fc4d87cf5ba643fb98af5bf2c430f3eff
https://github.com/Checkmk/checkmk/commit/504d550fc4d87cf5ba643fb98af5bf2c4…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
rulespecs: Improve typing a bit
CMK-13680
Change-Id: I192876a3cd73310fa304208e816f696c05243492
Commit: 1187ae24edbbf5518bfd5f4758b135b1ddd65cad
https://github.com/Checkmk/checkmk/commit/1187ae24edbbf5518bfd5f4758b135b1d…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/plugins/openapi/endpoints/ruleset/__init__.py
M cmk/gui/wato/pages/predefined_conditions.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
Get rid of `FilteredRulesetCollection`
Filtering should preserve the type.
CMK-13680
Change-Id: Ib47ab9f4621b5bb27dc400e7cd67ca5108fd473c
Commit: 490c304e85b829c69cf806c69899d2f093d4dec8
https://github.com/Checkmk/checkmk/commit/490c304e85b829c69cf806c69899d2f09…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
Misc. fixups in RulesetCollection hierarchy
Remove non-implemented methods
------------------------------
`save()` and `save_folder()` are only implemented in `AllRulesets` so
polymorphism doesn't make sense. Even worse, `save_folder()` was
*removed* from `SingleRulesetRecursively`, which breaks the LSP.
`SingleRulesetRecursively` is *not* an `AllRulesets` (duh!)
-----------------------------------------------------------
So let it inherit `RulesetCollection` directly. Even if that means
copying a bit of code.
Fix signature of `load*` functions
----------------------------------
`AllRulesets` cannot have an `only_varname` argument, by definition.
Similarly, this argument is required in `SingleRulesetRecursively`
CMK-13680
Change-Id: I86913ecdd69c868c5f9e231aa2466eb7827b507b
Commit: 88249bcfc87b603fd4e4a7e18cd29aea1f386009
https://github.com/Checkmk/checkmk/commit/88249bcfc87b603fd4e4a7e18cd29aea1…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-06-12 (Mon, 12 Jun 2023)
Changed paths:
M cmk/gui/watolib/rulesets.py
Log Message:
-----------
Move I/O out of class
The RulesetCollection mostly is a `MutableMapping[RulesetName, Ruleset]`
with a non-standard API. I/O doesn't belong here.
CMK-13680
Change-Id: Ic6ed290fbd7ae015490ba34a5c33bcf49b65e56f
Compare: https://github.com/Checkmk/checkmk/compare/f199f0c3a350...88249bcfc87b