[checkmk-commits] [tribe29/checkmk] 67717a: Extract language cookie handling from htmllib.html

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 67717a255effe128fe52f3c4fbde1bb7456919b5 https://github.com/tribe29/checkmk/commit/67717a255effe128fe52f3c4fbde1bb74… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-07 (Mon, 07 Jun 2021) Changed paths: M cmk/gui/htmllib.py M cmk/gui/login.py A cmk/gui/utils/language_cookie.py M cmk/gui/wato/user_profile.py M cmk/gui/wsgi/applications/utils.py Log Message: ----------- Extract language cookie handling from htmllib.html Change-Id: Ibf17dce81dda6f9d07330ed0e4dc17e836ccafc5 Commit: 1e0e7f724a5ae869750d0d75b2c8a3886e4724eb https://github.com/tribe29/checkmk/commit/1e0e7f724a5ae869750d0d75b2c8a3886… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-07 (Mon, 07 Jun 2021) Changed paths: M cmk/gui/globals.py M cmk/gui/plugins/openapi/livestatus_helpers/testing.py M cmk/gui/utils/script_helpers.py M cmk/gui/watolib/search.py M cmk/gui/wsgi/middleware.py Log Message: ----------- Simplify RequestContext constructor: Request and Response are now mandatory Change-Id: I6a8c4a04acd19080b0898c706eb43c6633ab788e Commit: a126f451ea74fea4ad12ef759122728b33dfeb06 https://github.com/tribe29/checkmk/commit/a126f451ea74fea4ad12ef759122728b3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-07 (Mon, 07 Jun 2021) Changed paths: M cmk/gui/htmllib.py A cmk/gui/utils/json.py M cmk/gui/wsgi/applications/checkmk.py M tests/unit/cmk/gui/conftest.py R tests/unit/cmk/gui/test_htmllib_json.py M tests/unit/cmk/gui/utils/test_html.py A tests/unit/cmk/gui/utils/test_json.py Log Message: ----------- Cleanup GUI json hacks a bit * Extract from htmllib to dedicated module * Do not patch at import time of a module anymore * Instead of this, the patch is now applied as context manager which is also able to revert it's actions. * The context manager is applied only in the Checkmk GUI application and the GUI unit tests which which activates it during request processing A dedicated JSONEncoder would still be better, but all call sites of e.g. json.dumps, json.loads and so on would have to care about it. Change-Id: I6ececfb9f45d328fc80f1ad2f6a07053eb6888be Compare: https://github.com/tribe29/checkmk/compare/59dfd9c2a8bf...a126f451ea74