[checkmk-commits] [tribe29/checkmk] 39f9bc: get_check_preview: rely on max_cachefile_age

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 39f9bc207c3c6abb7771fa3d9a965b87b099e2cc https://github.com/tribe29/checkmk/commit/39f9bc207c3c6abb7771fa3d9a965b87b… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-02-11 (Thu, 11 Feb 2021) Changed paths: M cmk/base/config.py M cmk/base/discovery/__init__.py Log Message: ----------- get_check_preview: rely on max_cachefile_age We no longer choose Mode.DISCOVERY over Mode.CACHED_DISCOVERY, but instead rely on the fact that max_cachefile_age is set to zero if no caches should be used, (as we did for other datasources anyway). Change-Id: I43f29fb126731366b18a9062573da751b4b5d0ed Commit: c70f21accd483f95d3578a3000a962f3a5b4b7f5 https://github.com/tribe29/checkmk/commit/c70f21accd483f95d3578a3000a962f3a… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-02-11 (Thu, 11 Feb 2021) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/discovery/__init__.py M tests/unit/cmk/base/sources/test_cmd_caching.py Log Message: ----------- discovery: consolidate caching options The handling of the caching options is consolidated into the discovery module. The code in cmk.base.automations only passes flags along. The functions * `discover_on_host` used by the automation 'inventory' and the automatic service discovery and * `get_check_preview` used by the automation 'try-inventory' no longer accept the argument 'use_caches'. Instead, they are passed the arguments 'use_cached_snmp_data' and 'max_cachefile_age'. The flag 'use_caches' was aplied to both the TCP and the SNMP data sources. That is wrong: The TCP data sources could be sending some data only once, in which case information would be missed by the checks. TCP sources *must* use the caches. The cache file of the SNMP data source will only contain the sections detected when the data was fetched. The set of detected sections is expected to change rarely, so depending on the use case, using the SNMP caches may not be desired. In particular: When hitting the "Full scan" button on the discovery page, we expect new sections to be detected. Change-Id: I4b801a382e62ebdfa8d08788cdf28580a5ac5397 Commit: 99afbc74fe934473aeacdf3c13f191c03c7aec2e https://github.com/tribe29/checkmk/commit/99afbc74fe934473aeacdf3c13f191c03… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-02-11 (Thu, 11 Feb 2021) Changed paths: M cmk/base/discovery/__init__.py M cmk/core_helpers/snmp.py M cmk/core_helpers/type_defs.py A cmk/fetchers/type_defs.py M tests/unit/cmk/base/sources/test_cmd_caching.py M tests/unit/cmk/core_helpers/test_fetchers.py Log Message: ----------- fetchers: remove redundant Mode We have changed cache handling, s.t. the dedicated CACHED_DISCOVERY mode is not needed anymore. Change-Id: I59222800587523c001b628041db5dacc53d99680 Compare: https://github.com/tribe29/checkmk/compare/b4ebfa8be3f9...99afbc74fe93