[checkmk-commits] Removed yet another strdup(), fixing a space leak on the way.

Module: check_mk Branch: master Commit: ad42e4cf5ac480b507a85781f8e658167508dfad URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ad42e4cf5ac480… Author: Sven Panne &lt;sp(a)mathias-kettner.de&gt; Date: Wed Aug 2 15:17:28 2017 +0200 Removed yet another strdup(), fixing a space leak on the way. Change-Id: I2c490c02e4772a923880d3a900a7845439b7adf7 --- livestatus/src/module.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/livestatus/src/module.cc b/livestatus/src/module.cc index 6d9a179..2aea007 100644 --- a/livestatus/src/module.cc +++ b/livestatus/src/module.cc @@ -22,7 +22,7 @@ // to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, // Boston, MA 02110-1301 USA. -// Needed for strdup and S_ISSOCK +// Needed for S_ISSOCK #define _XOPEN_SOURCE 500 // https://github.com/include-what-you-use/include-what-you-use/issues/166 @@ -909,7 +909,9 @@ void livestatus_parse_arguments(const char *args_orig) { return; // no arguments, use default options } - char *args = strdup(args_orig); + // TODO(sp) Nuke next_field and friends. Use C++ strings everywhere. + vector<char> args_buf(args_orig, args_orig + strlen(args_orig) + 1); + char *args = &args_buf[0]; while (char *token = next_field(&args)) { /* find = */ char *part = token; @@ -1078,8 +1080,6 @@ void livestatus_parse_arguments(const char *args_orig) { Warning(fl_logger_nagios) << "fl_socket_path=[" << fl_socket_path << "], fl_mkeventd_socket_path=[" << fl_mkeventd_socket_path << "]"; - - // free(args); won't free, since we use pointers? } void omd_advertize() {