[checkmk-commits] [tribe29/checkmk] d39623: SAML: refactor failed authentication logging

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d3962319a645140ee634753c4be87ab7709d052a https://github.com/tribe29/checkmk/commit/d3962319a645140ee634753c4be87ab77… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M cmk/gui/userdb/saml2/interface.py M tests/unit/cmk/gui/userdb/saml2/test_interface.py Log Message: ----------- SAML: refactor failed authentication logging * failed logins are raised as exceptions during the parsing by the client ** any 'is_condition_ok' or 'is_authentication_ok' calls after that are therefore redundant * exceptions by the client should not be raised as they may contain sensitive information Change-Id: If8a6deb4b246782733a83fe3beef3be9886b18b1 Commit: bf9b3cd5199e22661b82caa77cef3aa5f1a4d7de https://github.com/tribe29/checkmk/commit/bf9b3cd5199e22661b82caa77cef3aa5f… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M cmk/gui/userdb/saml2/interface.py M tests/unit/cmk/gui/userdb/saml2/test_interface.py Log Message: ----------- SAML: additional test case for condition "Audience" Responses for a different audience must be rejected. The client handles this for us, but it's still good to have a test case defined for awareness. CMK-11850 Change-Id: Ied868c9e0ae93fd143b8febe93857adb9d871780 Commit: c5e3439cf212ea6c9339c1a1380831dee3d6da33 https://github.com/tribe29/checkmk/commit/c5e3439cf212ea6c9339c1a1380831dee… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-02 (Mon, 02 Jan 2023) Changed paths: M cmk/gui/userdb/saml2/interface.py M tests/unit/cmk/gui/userdb/saml2/test_interface.py Log Message: ----------- SAML: custom exceptions Custom exceptions are not supported. CMK-11850 Change-Id: Ib31c2f08e37a002421520e2b8349f043da639883 Compare: https://github.com/tribe29/checkmk/compare/fea03f5406d2...c5e3439cf212