[checkmk-commits] Check_MK Git: check_mk: datasource program call: Simplified code

Module: check_mk Branch: master Commit: f4fd2fd334d5cf974533ffd0ffbbc17c86ae085b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f4fd2fd334d5cf… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Dec 11 11:45:56 2013 +0100 datasource program call: Simplified code --- modules/check_mk_base.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/modules/check_mk_base.py b/modules/check_mk_base.py index b70543e..11028ab 100644 --- a/modules/check_mk_base.py +++ b/modules/check_mk_base.py @@ -618,12 +618,7 @@ def get_agent_info_program(commandline): sys.stderr.write("Calling external program %s\n" % commandline) try: p = subprocess.Popen(commandline, shell = True, stdout = subprocess.PIPE, stderr = subprocess.PIPE) - stdout = "" - stderr = "" - while p.poll() is None: - response = p.communicate() - stdout += response[0] - stderr += response[1] + stdout, stderr = p.communicate() exitstatus = p.returncode except Exception, e: raise MKAgentError("Could not execute '%s': %s" % (commandline, e))