[checkmk-commits] [tribe29/checkmk] d92286: Add tests to `netapp_api_fcp`

Branch: refs/heads/snapshot/mathias.laurin/FEED-3874 Home: https://github.com/tribe29/checkmk Commit: d9228671127190ea8cb030f5e6a5052d19343b3e https://github.com/tribe29/checkmk/commit/d9228671127190ea8cb030f5e6a5052d1… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2019-08-07 (Wed, 07 Aug 2019) Changed paths: M checks/netapp_api_fcp A tests/unit/checks/generictests/datasets/netapp_api_fcp.py Log Message: ----------- Add tests to `netapp_api_fcp` Adding the tests required moving the calls to `get_rate()` from the parser to the check as `mock_item_state` only works in the check. Change-Id: I4a4900a92c9bb0c396639c13792609c7e7dfae6d Commit: 17a7e5510cd1f72268467e26ed6ed93475020b1c https://github.com/tribe29/checkmk/commit/17a7e5510cd1f72268467e26ed6ed9347… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2019-08-07 (Wed, 07 Aug 2019) Changed paths: A .werks/8901 M checks/netapp_api_fcp M tests/unit/checks/generictests/datasets/netapp_api_fcp.py Log Message: ----------- 8901 FIX Fixed calculation of latency for netapp check Average latency, average read latency, and average write latency are now calculated as a function of total_ops instead of the time. This complies with the formula from NetApp's Performance Management Design Guide. According to this guide, latency should be calculated as: latency(now) - latency(before) lat = --------------------------------- total_ops(now) - total_ops(before) and not as a function of time. This fixes FEED-3874. Change-Id: I527e8e77cff016559ae85e6bed173655bc34dfb4 Compare: https://github.com/tribe29/checkmk/compare/d92286711271%5E...17a7e5510cd1