21 Sep
2020
21 Sep
'20
8:22 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: d0b90476d54b4e197a493a14ef1095f5c872c3d2
https://github.com/tribe29/checkmk/commit/d0b90476d54b4e197a493a14ef1095f5c…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2020-09-21 (Mon, 21 Sep 2020)
Changed paths:
M cmk/gui/plugins/metrics/timeseries.py
M cmk/utils/prediction.py
Log Message:
-----------
TimeSeries object includes metadata about how to render itself
Commit deals with the refactoring consequences. As TimeSeries includes
render information, there is no need to deal with multi-types on curves,
once for the TimeSeries once for a list of tuples of render data and
TimesSeries.
The evaluation of an expression thus simplifies its return type to
List[TimeSeries]
CMK-5232
Change-Id: I8b7bbadc77aea54901b5834954952cdd337664c5
Commit: 87c9a83cd2ac14a8a4a6b82625d83f0f7c2afd8f
https://github.com/tribe29/checkmk/commit/87c9a83cd2ac14a8a4a6b82625d83f0f7…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2020-09-21 (Mon, 21 Sep 2020)
Changed paths:
M cmk/gui/plugins/metrics/timeseries.py
Log Message:
-----------
Harmonize metric stacking in Customgraphs
- Metrics always can stack, even on an underlying empty list of values or
Nones. It is not necessary thus to have a recipe that starts on
"area". Taking advantage of this combined graphs multiline metrics always
stack.
- Mirrored linestyle can also apply to multiline metrics. The expression
recipe is not aware of mirroring. The curve generator includes it for first
time and then the layout calculator applies the mirroring.
CMK-5232
Change-Id: I0adf42a9c6a32dc83076b2fe5470f53eb52b3cff
Commit: 329eac0a8f9b97cabeca9d76572931a4f4f55ed6
https://github.com/tribe29/checkmk/commit/329eac0a8f9b97cabeca9d76572931a4f…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2020-09-21 (Mon, 21 Sep 2020)
Changed paths:
M cmk/gui/plugins/metrics/timeseries.py
Log Message:
-----------
Harmonize colors in Customgraphs
The color picker for a metric is the ruling color for the output,
irrespective of what the metric system say the color of the metric shall
be. That is expected behavior. Multi-line curves already delivered their
own colors and where thus disobedient to color picker.
To better separate between Multi-line curves that now have same color, they
are faded on alternating entries. Like the combined graphs did.
- Forecast Graphs have hard defined colors and thus skip this
regulation. They cannot be embedded in a custom graph so it is safe.
- Combined Graphs generate their complete recipe. If the entire graph had
only one metric, all output curves turn rainbow colored(old behavior). If
more than a metric was defined, then there is alternating fading over all
entries(close enough to old behavior, which was at block level). As the
recipe is fully defined by the listed metrics, the compute_graph_curves
does not do recoloring fading alternating entries. Tests on combined graphs
color change, because now odd fading(keeps first metric(zero index)
preserved). It also imitates then result on CustomGraphs multi-line, which
fade color on odd entries.
- Custom graphs that generate multi-lines, here applies the color fading,
per metric block. To avoid conflict, the multi-line evaluator drops the
color info.
CMK-5232
Change-Id: I290dbe4c4dfa235e785d68f5af4c76c8337d1414
Compare: https://github.com/tribe29/checkmk/compare/0e0a61f6238b...329eac0a8f9b