[checkmk-commits] [tribe29/checkmk] edfb32: Correctly calculate missing context filters

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: edfb32d3777b6a389ce270697bde9c7b45e4444b https://github.com/tribe29/checkmk/commit/edfb32d3777b6a389ce270697bde9c7b4… Author: Óscar Nájera &lt;oscar.najera(a)tribe29.com&gt; Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/dashboard.py M cmk/gui/visuals.py Log Message: ----------- Correctly calculate missing context filters Because all needed filters are preloaded on pagemenu, when they are not set, they still give empty values, check has to be more strict Change-Id: Ia5497b5f838576c27f25c0a0697fccbb0be86c58 Commit: 5c3157ad50eac8ff04bcf75cf4bc3523e9d17dbf https://github.com/tribe29/checkmk/commit/5c3157ad50eac8ff04bcf75cf4bc3523e… Author: Óscar Nájera &lt;oscar.najera(a)tribe29.com&gt; Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/views.py M cmk/gui/visuals.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- Single_info context transform The context spec for single infos now includes a transform for in disk to match the VisualContext type, which implies filters are separate. It also needs a transform to extract from filter into single_spec dictionary. (It works correctly but is so ugly that it can't be a good option) An extra transformation is provided when importing views previous to this change(<2.1.0) to make sure context from disk is loaded correctly. The transform_old_visuals acts on views, and recursively on dashboard->daslet. Reports need an narrower step only for the context in element. Change-Id: Ib696f35601302d64f7550973ee89ca931dc7dc0d Commit: 2d0a5c50c7bef4ca70530b50501a489e187fc4c0 https://github.com/tribe29/checkmk/commit/2d0a5c50c7bef4ca70530b50501a489e1… Author: Óscar Nájera &lt;oscar.najera(a)tribe29.com&gt; Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/views.py Log Message: ----------- On views users can change saved filters Currently all the saved context filters are loaded on the view filter menu. Because there is no merging, instead is a direct selection between on disk or active filters. User can lively change the active filters of a view. Thus, don't filter them out. Filters become now users choice. Less surprises for the user. If he now deletes a set filter, it get deleted. Change-Id: I32c2834b1401fe28dd713862d26798ac6771ff16 Commit: 3fdd55e1a4e02b3b6e90da7a21e409675dd0448a https://github.com/tribe29/checkmk/commit/3fdd55e1a4e02b3b6e90da7a21e409675… Author: Óscar Nájera &lt;oscar.najera(a)tribe29.com&gt; Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/plugins/webapi/grafana.py Log Message: ----------- Some cleanup in combined graphs Remove duplicated function that has no special functionality. This creates a cleanup in grafana webapi too, which now uses a raw edition function. I don't think we were explicitly making this feature CEE, it was only a bad import limitation. Usage is for availability dashboard annotations, an obscure and undocumented feature. Still tested that it now works. Rendering of combined graphs in Grafana remains CEE feature. Change-Id: I074d0b85a0c840c87758f9cc33f77363dd31a118 Commit: 3e7ee0edddace32fe26fef200d8ef2934eb62027 https://github.com/tribe29/checkmk/commit/3e7ee0edddace32fe26fef200d8ef2934… Author: Óscar Nájera &lt;oscar.najera(a)tribe29.com&gt; Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/visuals.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- Remove add_context_to_uri_vars We shall never be using the request vars as a communication bus! Change-Id: Ib811aef359417e055fa20478ed199549cc1fa9ec Compare: https://github.com/tribe29/checkmk/compare/91ac71277108...3e7ee0edddac