[checkmk-commits] 5698 FIX Windows agent: space in MRPE plugin path resulted in wrong plugin name

Module: check_mk Branch: master Commit: 50841c33a841cfe2937b7a9e881e8c9ee1d25701 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=50841c33a841cf… Author: Jukka Aro <ja(a)mathias-kettner.de> Date: Mon Jan 22 14:00:55 2018 +0100 5698 FIX Windows agent: space in MRPE plugin path resulted in wrong plugin name If the path of a(n included) MRPE plugin contained one or more spaces, the plugin name was parsed incorrectly. Quotes were incorrectly required for the whole command line including parameters within quotes, making it impossible to distinguish between a script path containing space(s) and space-separated script parameters. Now the MRPE plugin path must be enclosed in double quotes (") in order to be processed correctly. The same applies for script parameters with whitespace: also they must be separately enclosed in quotes. Example: check_mk.ini: [mrpe] include = C:\Temp\my.cfg C:\Temp\my.cfg: check = Dummy "C:\Program Files (x86)\check_mk\mrpe\check_crit.bat" some parameter "with space" --- .werks/5698 | 30 ++++++++ agents/windows/Makefile.am | 3 +- agents/windows/build_version | 2 +- agents/windows/check_mk.example.ini | 27 ++++++++ agents/windows/sections/SectionMRPE.cc | 91 +++++++++++++++++-------- agents/windows/stringutil.h | 4 +- agents/windows/test/sections/SectionMRPETest.cc | 71 +++++++++++++++++++ agents/windows/test/stringutilTest.cc | 39 ++++++++++- 8 files changed, 233 insertions(+), 34 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=50841c33a8…