[checkmk-commits] [tribe29/checkmk] dac806: Remove redundant logic

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: dac80622ddd6462c1d21709021b1c670fb5a3222 https://github.com/tribe29/checkmk/commit/dac80622ddd6462c1d21709021b1c670f… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-01-14 (Tue, 14 Jan 2020) Changed paths: M cmk/gui/dashboard.py Log Message: ----------- Remove redundant logic Change-Id: I48876e06e9ff9e79f553de25d6b0f7d6139f6b71 Commit: daa3f9e485afd1ffe65e41bc5190f34eb0d9145c https://github.com/tribe29/checkmk/commit/daa3f9e485afd1ffe65e41bc5190f34eb… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-01-14 (Tue, 14 Jan 2020) Changed paths: M cmk/gui/visuals.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- Make get_context_from_uri_vars work like _get_singlecontext_html_vars Change-Id: I695b0495b91099acbf51214b3d235d8d7d9b0bec Commit: fb81bec2500ad2cb611053704eb5c1df42820065 https://github.com/tribe29/checkmk/commit/fb81bec2500ad2cb611053704eb5c1df4… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-01-14 (Tue, 14 Jan 2020) Changed paths: M cmk/gui/dashboard.py M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/dashboard/view.py M cmk/gui/plugins/views/utils.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/plugins/webapi/grafana.py M cmk/gui/views.py M cmk/gui/visuals.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- Make arguments of some utility function explicit Instead of passing around visuals (and pseudo visuals) to the functions and only using a small subset of the properties, the needed properties are now explicitly handed over to the functions. Change-Id: If9a241106411ee328cdc211d2562b40b8a6f605b Commit: 8f0adbb34d7c0c59b92f33973d2b3443d8d56164 https://github.com/tribe29/checkmk/commit/8f0adbb34d7c0c59b92f33973d2b3443d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-01-14 (Tue, 14 Jan 2020) Changed paths: M cmk/gui/dashboard.py Log Message: ----------- Fix bug cloning an existing view to a dashlet Change-Id: I615362b6e4f5138163d067cbbd42a9e02fb2e754 Commit: f46da9205393fed7c911d1e7bb1b12a3a391f215 https://github.com/tribe29/checkmk/commit/f46da9205393fed7c911d1e7bb1b12a3a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-01-14 (Tue, 14 Jan 2020) Changed paths: M cmk/gui/dashboard.py M cmk/gui/plugins/dashboard/stats.py M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/dashboard/view.py M tests/unit/cmk/gui/test_dashboard.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Addition to #10547: Improve existing view link dashlet creation When adding a new dashlet, which should refer to an existing view, a dedicated dialog for selecting the view is needed. This is necessary because the "dashlet edit" dialog needs to know the datasource and infos of a view before it can be used to edit a linked view dashlet Now reusing the dialog which is used for cloning existing views as dashlets. Change-Id: Id27b74022a5552866a97e6d7f47bfa5250ceccac Commit: 17fec3afadaf3487675c3c0a2339a478dd7ba1fc https://github.com/tribe29/checkmk/commit/17fec3afadaf3487675c3c0a2339a478d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-01-14 (Tue, 14 Jan 2020) Changed paths: M cmk/gui/crash_reporting.py M cmk/gui/dashboard.py M cmk/gui/wsgi/applications/checkmk.py Log Message: ----------- Improve dashlet error handling Our own exceptions are displayed as before, unhandled exceptions now result in a crash report. Change-Id: I82dac8c6634c2db1be41101b44137868716fb867 Compare: https://github.com/tribe29/checkmk/compare/155aba4ccbc0...17fec3afadaf