[checkmk-commits] [tribe29/checkmk] 8966bd: Remove dependencies on config from cmk.base.snmp

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8966bd7ad46495154d87360a05a38f5c1f8611b0 https://github.com/tribe29/checkmk/commit/8966bd7ad46495154d87360a05a38f5c1… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-08 (Mon, 08 Jun 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/config.py M cmk/base/modes/check_mk.py M cmk/base/snmp.py M cmk/base/snmp_utils.py M cmk/utils/type_defs.py Log Message: ----------- Remove dependencies on config from cmk.base.snmp The `create_snmp_host_config` instantiates a HostConfig, performs some sanitization on its arguments, and returns the result of a method from HostConfig. The code should therefore be consolidated by moving it to `cmk.base.config.HostConfig`. However, the argument sanitization calls `ip_lookup`, which imports `config`: circular imports. For, now, we therefore move the function somewhere else. `ScanFunction` also goes to `cmk.utils.type_defs` to avoid more circular imports. Magically importing the config *in* a function never makes sense. If anything, configuration must be passed to functions. CMK-4610 Change-Id: Iba3493711b4ac3ce6c4236da240a64a3039c42a7 Commit: 1db868ddeb4cd79d49c49afa1a60eb783fefaf97 https://github.com/tribe29/checkmk/commit/1db868ddeb4cd79d49c49afa1a60eb783… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-08 (Mon, 08 Jun 2020) Changed paths: M cmk/base/snmp.py M cmk/fetchers/factory.py M cmk/fetchers/snmp_backend/classic.py M cmk/fetchers/snmp_backend/stored_walk.py M cmk/utils/snmp_table.py M cmk/utils/type_defs.py M tests-py3/integration/cmk/base/snmp/test_snmp.py M tests-py3/integration/cmk/utils/test_snmp_table.py M tests-py3/unit/cmk/base/test_snmp_utils.py M tests-py3/unit/cmk/fetchers/test_classic_snmp.py M tests-py3/unit/cmk/utils/test_snmp_table_unit.py Log Message: ----------- Simplify code by passing snmp_config to backends CMK-4610 Change-Id: I883221a9c25541b06ac663e7f80a2f3e24c8ee90 Commit: b39b3f39a708d4fa1576f1f673ad471cdff8dc32 https://github.com/tribe29/checkmk/commit/b39b3f39a708d4fa1576f1f673ad471cd… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-08 (Mon, 08 Jun 2020) Changed paths: R cmk/base/cleanup.py M cmk/base/config.py M cmk/base/core.py M cmk/base/discovery.py M cmk/base/inventory.py M cmk/base/item_state.py M cmk/base/snmp.py A cmk/utils/cleanup.py Log Message: ----------- Move `cleanup` from base to utils The module itself has no deps on base. With this change, we get rid of all the dependencies of `cmk.base.snmp` on `base`. Now, we are able to increase the cohesion of our SNMP code by moving `cmk.utils.snmp_table` and `cmk.base.snmp` back to a common package, possibly outside of `cmk.utils`. CMK-4610 Change-Id: I18654d4883c9c4e19671dec7e4fe4aacad795876 Compare: https://github.com/tribe29/checkmk/compare/171f9e04bd48...b39b3f39a708