[checkmk-commits] [tribe29/checkmk] e0283b: Activate changes: remove dependency to htmllib

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e0283bac98d92d40429f406634cf393989916f33 https://github.com/tribe29/checkmk/commit/e0283bac98d92d40429f406634cf39398… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2020-08-06 (Thu, 06 Aug 2020) Changed paths: M cmk/gui/watolib/activate_changes.py Log Message: ----------- Activate changes: remove dependency to htmllib * replace html.request with request wherever possible * duplicate some minor uri handling function from htmllib * doctest for that Change-Id: Iaf3414c2c8e38bae5810c26aeb1c494cd0a705d4 Commit: 97c0a9ade05727b265fc26421b86f4cf6a65a14e https://github.com/tribe29/checkmk/commit/97c0a9ade05727b265fc26421b86f4cf6… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2020-08-06 (Thu, 06 Aug 2020) Changed paths: M cmk/gui/plugins/openapi/livestatus_helpers/testing.py Log Message: ----------- Livestatus helpers: fix test-crash in parse_check_mk_version Change-Id: I6c225df47fae4c12e4602748f8060332b10cab80 Commit: 6cf1f786b6c89f3c2db70a39843f9519ff2092df https://github.com/tribe29/checkmk/commit/6cf1f786b6c89f3c2db70a39843f9519f… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2020-08-06 (Thu, 06 Aug 2020) Changed paths: M cmk/gui/wsgi/applications/rest_api.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/wsgi/test_wsgi_router.py Log Message: ----------- REST-API: prevent Flask from swallowing Exceptions in debug mode Change-Id: I780c04db8bd964eceb807b5f3c73b0680396be85 Commit: 6dbe69884679d944f895a18b23ccc4915677a5df https://github.com/tribe29/checkmk/commit/6dbe69884679d944f895a18b23ccc4915… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2020-08-06 (Thu, 06 Aug 2020) Changed paths: M cmk/gui/plugins/openapi/endpoints/activate_changes.py Log Message: ----------- REST-API: activate changes: improve message, remove comment Change-Id: I6b8b091f7a90a92a45060d98ed2b6da1d27d6eb9 Commit: 190a54f4fff9166c219f0669c4be8d8b8ea4368f https://github.com/tribe29/checkmk/commit/190a54f4fff9166c219f0669c4be8d8b8… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2020-08-06 (Thu, 06 Aug 2020) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- test: remove implicit inlining of background jobs on automation calls fixture on activate changes, a Process is spawned which gets periodically checked for liveness by kill(pid, 0). Due to inlining of the Process and the code having submitted it's pid via a convoluted save-load operation on the filesystem to the main process, the process checks ITS OWN PID for liveness and waits until it completes. As it is checking on itself this is an endless loop. :-( In an ideal world, the activate changes code should be refactored to use the standard background job interface, though this is another task for another day. Change-Id: I533c935f483a5cc45e6ef874a7f9f9a941da8f7a Commit: 55191c33ab8307ac4f014dece3bf9595db423a6e https://github.com/tribe29/checkmk/commit/55191c33ab8307ac4f014dece3bf9595d… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2020-08-06 (Thu, 06 Aug 2020) Changed paths: M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_activate_changes.py Log Message: ----------- REST-API: activate changes test add LiveStatus mocking to activate-changes test, because I realized that requests were being made by the code, the error to connect would not surface in the code but rather, after the connection timed out, the test continued to run. This also explains why the test took so long to run. Now it is actually covering more code, is more correct and runs faster. Change-Id: I62a3043acfe2711c143ed411c7619630f5e9bd7b Compare: https://github.com/tribe29/checkmk/compare/6229274831c3...55191c33ab83