[checkmk-commits] [tribe29/checkmk] 3efe01: Add some run time test to ensure we have host attr...

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 3efe01d43ca83fe5e29a15dc63888ea96db67967 https://github.com/tribe29/checkmk/commit/3efe01d43ca83fe5e29a15dc63888ea96… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-10-19 (Wed, 19 Oct 2022) Changed paths: M cmk/gui/fields/utils.py Log Message: ----------- Add some run time test to ensure we have host attributes registered Makes it easier to understand import order issues. Without this the unit test may show some symptoms which are hard to understand: ``` webtest.app.AppError: Bad response: 500 INTERNAL SERVER ERROR (not 200) '{"title": "Mismatch between endpoint and internal data format. ", "status": 500, "detail": "This could be due to invalid or outdated configuration, or be an error of the implementation. Please check your *.mk files in case you have modified them by hand and run cmk-update-config. If the problem persists afterwards, please report a bug.", "ext": {"errors": {"meta_data": ["Not a string, but a dict", "Tag group name must start with \'tag_\'", "Unknown field."]}, (...) ``` With the change we now get a more meaningful error message which points us directly to the specific issue. Of course there are specific unit tests for that, but they fail together with more than 20 other tests which makes it hard to find the right track. Change-Id: I3e90a2fce347936ca75aed4c2cf4b452598f9e34 Commit: 161ae9a62060f2a1bc165ef95893ee2a1577e452 https://github.com/tribe29/checkmk/commit/161ae9a62060f2a1bc165ef95893ee2a1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-10-19 (Wed, 19 Oct 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/host_config.py A cmk/gui/plugins/openapi/restful_objects/api_error.py M cmk/gui/plugins/openapi/restful_objects/decorators.py M cmk/gui/plugins/openapi/restful_objects/response_schemas.py M tests/unit/cmk/gui/plugins/openapi/test_error.py Log Message: ----------- Extract ApiError to dedicated module This helps to reduce the scope of openapi related imports triggered by cmk.gui.context at least a little bit. Now the Endpoint import does not pull the whole response_schema module anymore. This is still not ideal, but a small improvement which enables us to clean up some import cycles later on. Change-Id: I8e146ec388f16a99e9caa92115fbbaace8eeed8d Commit: 41b4fd99af24c4da66d466a42057c5a9588a163f https://github.com/tribe29/checkmk/commit/41b4fd99af24c4da66d466a42057c5a95… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-10-19 (Wed, 19 Oct 2022) Changed paths: M cmk/gui/pdf.py M tests/Makefile Log Message: ----------- Break pdf graph cycle Remove graph enterprise plugin import from cmk.gui.pdf. Change-Id: Id7518c62e93387f526eaec1cd990c999dc11c7b3 Compare: https://github.com/tribe29/checkmk/compare/7d54d48dbcad...41b4fd99af24