[checkmk-commits] [tribe29/checkmk] cd3d87: Add tests for valuespec.CascadingDropdown

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: cd3d87c8d08622755d50008c13c9be90fd727b16 https://github.com/tribe29/checkmk/commit/cd3d87c8d08622755d50008c13c9be90f… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-09-12 (Mon, 12 Sep 2022) Changed paths: M cmk/gui/valuespec.py M tests/unit/cmk/gui/valuespecs/test_vs_cascadingdropdown.py Log Message: ----------- Add tests for valuespec.CascadingDropdown * removed some dead code (typing showed that the value can never be of type tuple when isinstance(value, tuple) is called. * added Literal type for orientation * removed explicit typing for first_choice and choice as mypy is capable to find out the types by its own, and wrong types were used for the explicit typing. Change-Id: Ic37e8c65909440afbd62aab2beb38bdf1d62ca6a Commit: 326899e969e96c3c206b4a9def50bbf970c2557b https://github.com/tribe29/checkmk/commit/326899e969e96c3c206b4a9def50bbf97… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-09-12 (Mon, 12 Sep 2022) Changed paths: M cmk/gui/valuespec.py M tests/unit/cmk/gui/valuespecs/test_vs_cascadingdropdown.py Log Message: ----------- Refactor CascadingDropdownChoice Driven by comments in the associacted unittests. Change-Id: I89ee964ef3d79f36d93dd7e815b10733f46b3b61 Commit: 4ce61ba042d8892d32506eeea8d6c4dbee69b869 https://github.com/tribe29/checkmk/commit/4ce61ba042d8892d32506eeea8d6c4dbe… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-09-12 (Mon, 12 Sep 2022) Changed paths: M checks/apc_symmetra_test M checks/check_mail_loop Log Message: ----------- Fixed doctests. Change-Id: I9c803af76c56867a1fabd4a3341d2d8354092d04 Compare: https://github.com/tribe29/checkmk/compare/77223c23bbc3...4ce61ba042d8