[checkmk-commits] [tribe29/checkmk] 329311: Cleanup commented out code

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 329311ed794eed032af5c5e3c1938dbaab8b986d https://github.com/tribe29/checkmk/commit/329311ed794eed032af5c5e3c1938dbaa… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M cmk/gui/plugins/visuals/filters.py Log Message: ----------- Cleanup commented out code Change-Id: I5a0b416ce415760c10a729cc15e1a9f683babef5 Commit: 4b157d6f8466acd2595ab132accde74aeacf5b63 https://github.com/tribe29/checkmk/commit/4b157d6f8466acd2595ab132accde74ae… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M cmk/gui/plugins/visuals/filters.py M cmk/gui/views.py Log Message: ----------- Move view specific request variable hacks to start of request This logic only needs to be executed when initially accessing a view, not e.g. during subsequent AJAX calls. To have a cleaner separation and have all variables set before the context is computed from the variables, we move it to the central entry point of the views: page_view(). Change-Id: Ie3b996380448e02e195706943cce8913a01d980d Commit: 592666608b9fe66aa4420c4583bd5e12976c0c7c https://github.com/tribe29/checkmk/commit/592666608b9fe66aa4420c4583bd5e129… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M cmk/gui/views.py M cmk/gui/visuals.py Log Message: ----------- Unbreak single group views for host / services The verification of the single contexts has been introduced some weeks ago and now prevents rendering of "host of host group X" views. To make the views usable again the recently introduced verification is being disabled for this special case. This is another workaround on top of a collection of workarounds to make the linking from host group lists to members of single host group page possible in the current structure. Change-Id: I52b7e7c311720f66d97da2eb1388cf452ef20382 Commit: fe116617359430147e23fe047405517def0bd46e https://github.com/tribe29/checkmk/commit/fe116617359430147e23fe047405517de… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/views.py M web/htdocs/themes/facelift/scss/_pages.scss Log Message: ----------- Fix "add view/graph/..." action from popup menus Improve some styling issues on the way Change-Id: If79e9f2b01698f437d0f98762bc7478b03048e47 Commit: f4a6dfb3c9ae61ddb74005a50a578f755cdaf66a https://github.com/tribe29/checkmk/commit/f4a6dfb3c9ae61ddb74005a50a578f755… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M cmk/gui/page_menu.py M web/htdocs/js/modules/page_menu.js M web/htdocs/js/modules/popup_menu.js M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Use general popup menu code for the page menu dropdowns * Some naming clarifications on the way * Add some comments to clarify the purpose of functions Change-Id: I5228285bf6678a0b50f6e3ebb1c47830bdd2a117 Commit: 2fd1c7e50576d441411b3f410b064a8e52ac5589 https://github.com/tribe29/checkmk/commit/2fd1c7e50576d441411b3f410b064a8e5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M cmk/gui/page_menu.py M tests/unit/cmk/gui/test_page_menu.py M web/htdocs/js/modules/page_menu.js Log Message: ----------- Some naming clarification and unused code cleanup The thing that opens when clicking on a title of the page menu is named "page menu dropdown" or "dropdown" in short. Respect that in the JS code. Change-Id: I7ac2caa2c9c066cd96679057acf5d73df59f717f Commit: 2f6bb771d9bb8de4d32f054a1f53e0498103061d https://github.com/tribe29/checkmk/commit/2f6bb771d9bb8de4d32f054a1f53e0498… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M cmk/gui/page_menu.py M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Refactor page menu to use the generic popup menu Change-Id: I633e8cb2503e18815667506e74a7e778b1bead48 Commit: 005104579fba09d6db904b921e52989722c7dc8b https://github.com/tribe29/checkmk/commit/005104579fba09d6db904b921e5298972… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/page_menu.py M cmk/gui/plugins/sidebar/main_menu.py M web/htdocs/js/modules/page_menu.js M web/htdocs/js/modules/popup_menu.js Log Message: ----------- Generalize switching between popups When one page menu dropdown was opened it was possible to hover the next menu title to switch to the other dropdown. This specific feature has now been added to the generic popup menu code. To use this feature the popups need to have a common CSS class which needs to be added as popup_group="class" argument to the popup_trigger call in python. Change-Id: I75ad4a689f13a136972c048542120613d99ee92d Commit: 3b2c86e195a3570675e3aaecb87b2c626811a7d2 https://github.com/tribe29/checkmk/commit/3b2c86e195a3570675e3aaecb87b2c626… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-07 (Fri, 07 Aug 2020) Changed paths: M cmk/gui/page_menu.py M cmk/gui/views.py M cmk/gui/visuals.py Log Message: ----------- Make "add to" page menu of views work Change-Id: I799381ff1666e5727656fbda1c95e06c6a3ddfe9 Compare: https://github.com/tribe29/checkmk/compare/a00476f7b2ad...3b2c86e195a3