[checkmk-commits] [tribe29/checkmk] e4bbd6: Moved interface implementations into headers.

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e4bbd61a154f8a8ceb41c5cbad35ef28edb77ee6 https://github.com/tribe29/checkmk/commit/e4bbd61a154f8a8ceb41c5cbad35ef28e… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-01-20 (Fri, 20 Jan 2023) Changed paths: M livestatus/src/Makefile.am R livestatus/src/NebContact.cc M livestatus/src/NebContact.h R livestatus/src/NebHost.cc M livestatus/src/NebHost.h R livestatus/src/NebService.cc M livestatus/src/NebService.h M packages/livestatus/include/livestatus/Interface.h Log Message: ----------- Moved interface implementations into headers. At the current point in time, the Livestatus interface will change quite often. So after a change in livestatus/Interface.h, *4* files had to be changed, which was quite annoying. Moving the implementations to the headers cuts down the changes by half, which is quite a relief. The implementations should be tiny, anyway, otherwise we would be doing something wrong: They should just be tiny views of the underlying data structures. And finally: If the compiler can figure out enough types at compilation time, it can inline the abstractions, perhaps even into one another. This is probably not very relevant, but if we are very lucky, this cuts down the cost of the abstractions a bit. Perhaps we can even merge all the interface implementations into a single header like InterfaceImplNeb.h, but that might be too much. In the end it's all a balancing act between readability, dependencies and maintainability. Let's see... Change-Id: I13e638d7e86ddb3e25ca8ce22356d584c41f2744 Commit: cba18d8b51d45d5414ffc3816afb61777e925e01 https://github.com/tribe29/checkmk/commit/cba18d8b51d45d5414ffc3816afb61777… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-01-20 (Fri, 20 Jan 2023) Changed paths: M livestatus/src/NagiosCore.cc M livestatus/src/NebContact.h Log Message: ----------- Removed ToIContact, we always know what to construct. Change-Id: I948a26454f7cd48b17a736857b9132606e5ab938 Commit: 66df81736d994d756f123a86e2660394ca05c702 https://github.com/tribe29/checkmk/commit/66df81736d994d756f123a86e2660394c… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-01-20 (Fri, 20 Jan 2023) Changed paths: M livestatus/src/NagiosCore.cc Log Message: ----------- Less downcasting, we already know the type in question. Change-Id: I50dd76169aee87589f8ec0531181331324118a90 Compare: https://github.com/tribe29/checkmk/compare/684190ad56be...66df81736d99