[checkmk-commits] Check_MK Git: check_mk: cisco_qos: remove print, that broke WATO

Module: check_mk Branch: master Commit: 67dc7f70b7ed9779814d0e3ab5d6df53676ef127 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=67dc7f70b7ed97… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Mar 1 11:13:50 2011 +0100 cisco_qos: remove print, that broke WATO --- ChangeLog | 1 + README.writing_checks | 6 ++++++ checks/cisco_qos | 2 -- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 06a904e..7ccea6a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -33,6 +33,7 @@ * hp_proliant_*: improve scan function (now just looks for "proliant") * FIX: cisco_temp_perf: fix return state in case of WARNING (was 0 = OK) * FIX: repair PNP template for df when using trends + * FIX: cisco_qos: fix WATO exception (was due to print command in check) Multisite: * FIX: fix json/python Webservice diff --git a/README.writing_checks b/README.writing_checks index b473704..6aeb27b 100644 --- a/README.writing_checks +++ b/README.writing_checks @@ -143,6 +143,12 @@ SNMP based checks: * Only use numeric OIDs in your checks. Name based OIDs rely on MIB files and the check won't work when the MIB files are not in place. +Forbidden things: +* Neither the check- nor the inventory function may use the print command + or otherwise output any data to stdout or stderr nor otherwise communicate + with the outside. An rare exception to this are checks that need a dedicated + data storage (such as logwatch: it keeps unread log messages in files). + Manpages * Each check *must* have a man page. This should be: diff --git a/checks/cisco_qos b/checks/cisco_qos index 1a6e6cc..20a46ac 100644 --- a/checks/cisco_qos +++ b/checks/cisco_qos @@ -193,8 +193,6 @@ def check_cisco_qos(item, params, info): perfdata.append( (name, rate, warn, crit, min, max) ) except MKCounterWrapped, e: wrapped = True - # continue, other counters might wrap as well - print e # if at least one counter wrapped, we do not handle the counters at all if wrapped: