[checkmk-commits] [tribe29/checkmk] 4da146: mtr agent plugin: refactor for better unit testabi...

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 4da146c2a0d1817fee404a2f697dd242fbd0ba66 https://github.com/tribe29/checkmk/commit/4da146c2a0d1817fee404a2f697dd242f… Author: Joerg Herbel &lt;joerg.herbel(a)tribe29.com&gt; Date: 2021-08-19 (Thu, 19 Aug 2021) Changed paths: M agents/plugins/mtr.py Log Message: ----------- mtr agent plugin: refactor for better unit testability Change-Id: I55040b9a34bec6a953eef44f8fbadcb650c9647d Commit: e15e65de220fd19224dac73e9155789faf87cd03 https://github.com/tribe29/checkmk/commit/e15e65de220fd19224dac73e9155789fa… Author: Joerg Herbel &lt;joerg.herbel(a)tribe29.com&gt; Date: 2021-08-19 (Thu, 19 Aug 2021) Changed paths: A tests/agent-plugin-unit/test_mtr.py Log Message: ----------- Add unit test for agent plugin mtr In Python 3, this plugin currently crashes. We will fix this in the following commits. Change-Id: I7885d49cba715b726911cf4003e18287486d4516 Commit: 36962eddbd1f21bd2030ae1b74edf287aad4baad https://github.com/tribe29/checkmk/commit/36962eddbd1f21bd2030ae1b74edf287a… Author: Joerg Herbel &lt;joerg.herbel(a)tribe29.com&gt; Date: 2021-08-19 (Thu, 19 Aug 2021) Changed paths: M agents/plugins/mtr.py Log Message: ----------- mtr agent plugin: remove unicodedata.normalize This function is problematic for python 2/3 compatibility (expects unicode in python 2 and strings in python 3). Furthermore, in its current state, the plugin crashes anyway for non-ascii characters in hostnames. Anyway, such cases should not occur and also cannot be configured in the Checkmk GUI. Change-Id: I77fa09526d89a946fbd3feb2b8ee24b798eae2ba Commit: 336aab9d15c23c289c6756210ff8ccb30089dc9a https://github.com/tribe29/checkmk/commit/336aab9d15c23c289c6756210ff8ccb30… Author: Joerg Herbel &lt;joerg.herbel(a)tribe29.com&gt; Date: 2021-08-19 (Thu, 19 Aug 2021) Changed paths: A .werks/13120 M agents/plugins/mtr.py M tests/agent-plugin-unit/test_mtr.py Log Message: ----------- 13120 FIX MTR agent plugin: Make usable with Python 3 Under Python 3, the MTR agent plugin crashed with: <tt>AttributeError: 'str' object has no attribute 'decode'</tt>. This has been fixed. Note that you need to update the agent on affected hosts for this werk to come into effect. Closes #390 Change-Id: I0ff5c8b021c2301210afb80878d47563a47262f0 Commit: bba181dc2e126b38f3b2b74f9c2f55a0c3e5a4ed https://github.com/tribe29/checkmk/commit/bba181dc2e126b38f3b2b74f9c2f55a0c… Author: Joerg Herbel &lt;joerg.herbel(a)tribe29.com&gt; Date: 2021-08-19 (Thu, 19 Aug 2021) Changed paths: M agents/plugins/mtr.py Log Message: ----------- mtr agent plugin: small improvement Change-Id: If3da5c1c6f18fc3068d8ba523f431fae51ac5768 Compare: https://github.com/tribe29/checkmk/compare/9a5a03241828...bba181dc2e12