[checkmk-commits] [tribe29/checkmk] 9d02be: Add missing `raise NotImplementedError()` to fetchers

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9d02be80536ba0a455ed5e67d90d80dd99ae4b31 https://github.com/tribe29/checkmk/commit/9d02be80536ba0a455ed5e67d90d80dd9… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/fetchers/_base.py Log Message: ----------- Add missing `raise NotImplementedError()` to fetchers Change-Id: I0ee8aa42a4b4af38812142ff6f3fd0873379a81c Commit: 64517a3149a409a50392318480535913eec03cf0 https://github.com/tribe29/checkmk/commit/64517a3149a409a50392318480535913e… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/base/checkers/_abstract.py M cmk/fetchers/_base.py Log Message: ----------- API: Try to protect the API with `@final` CMK-5450 Change-Id: I03481049bb4ebcae72a05df9adcdc2e2dcaf7209 Commit: a716fd98373db2e8217df34fcf01fb598bb0144c https://github.com/tribe29/checkmk/commit/a716fd98373db2e8217df34fcf01fb598… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/checkers/_abstract.py M cmk/base/checkers/_checkers.py M cmk/base/checkers/agent.py M cmk/base/checkers/ipmi.py M cmk/base/checkers/piggyback.py M cmk/base/checkers/programs.py M cmk/base/checkers/snmp.py M cmk/base/checkers/tcp.py M cmk/base/discovery.py M cmk/base/inventory.py M cmk/base/modes/check_mk.py M cmk/fetchers/__init__.py M cmk/fetchers/_base.py M cmk/fetchers/ipmi.py M cmk/fetchers/piggyback.py M cmk/fetchers/program.py M cmk/fetchers/snmp.py M cmk/fetchers/tcp.py M tests/unit/cmk/base/checkers/conftest.py M tests/unit/cmk/base/checkers/test_agent.py M tests/unit/cmk/base/checkers/test_cmd_caching.py M tests/unit/cmk/base/checkers/test_tcp_data_source.py M tests/unit/cmk/base/test_modes_check_mk.py M tests/unit/cmk/fetchers/test_fetchers.py Log Message: ----------- API: Localize FileCache serialize and deserialize This change moves the serialization part of FileCache to the FileCache class, where the deserialization already was. On top of the better maintainability, this change brings a series of general improvements: - Typing of FileCache is stricter and safer: It is not possible anymore to instantiate, for example, PiggyBack with a DefaultAgentFileCache, &c. - Also regarding typing: The sources now explicitly instantiate and return the correct FileCache type. - The sources now directly instantiate FileCache objects instead of going through serialization and deserialization. - The new API is consistent with the other factories (parser, summarizer, &c.) - The new API should also let us change the `__init__` of the FileCache classes, for example by emptying NoCache.__init__(). We still group the global variables in a FileCacheFactory class. The class may be removed once the globals are not global anymore. CMK-5450 Change-Id: I463b392a6efb6c23e1fa5d67297ecf6c6d1963ce Commit: d520105ddb80233d1d54f1d4a9272468d86eb6f3 https://github.com/tribe29/checkmk/commit/d520105ddb80233d1d54f1d4a9272468d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/fetchers/ipmi.py M cmk/fetchers/piggyback.py M cmk/fetchers/program.py M cmk/fetchers/snmp.py M cmk/fetchers/tcp.py M tests/unit/cmk/fetchers/test_fetchers.py Log Message: ----------- API: Improve Fetcher API We make the field of the Fetchers public and final. As it comes from outside anyway, it is not the Fetcher's responsibility to hide it. Even when it was private, the values were actually displayed by `__repr__()`. The remaining private attributes clarify the intent of the class. The public attributes make the Fetchers fully black-box testable. It should also makes sense to the user that a TCP fetcher, for example, has an `address` and an `encryption_settings` attribute. This also lets us fix some typing issues. Now, the Fetchers are also more consistent with args/kwargs in `__init__()`. CMK-5450 Change-Id: I20cb90ab9c1276925ca4a3fc2f1432da095679e4 Commit: 8e528ede6371e786dc0c1fcd8b6d80bd91ed7802 https://github.com/tribe29/checkmk/commit/8e528ede6371e786dc0c1fcd8b6d80bd9… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/base/checkers/_abstract.py M cmk/base/checkers/fetcher_configuration.py M cmk/base/checkers/ipmi.py M cmk/base/checkers/piggyback.py M cmk/base/checkers/programs.py M cmk/base/checkers/snmp.py M cmk/base/checkers/tcp.py M cmk/fetchers/__init__.py M cmk/fetchers/_base.py M cmk/fetchers/ipmi.py M cmk/fetchers/piggyback.py M cmk/fetchers/program.py M cmk/fetchers/snmp.py M cmk/fetchers/tcp.py M tests/unit/cmk/base/checkers/test_agent.py M tests/unit/cmk/base/checkers/test_tcp_data_source.py M tests/unit/cmk/fetchers/test_fetchers.py Log Message: ----------- API: Serialize and deserialize Fetcher in Fetcher This consolidates the API in that the serialization and deserialization methods are in the same class. This also lets us separate concerns (serialization and instantiation of the Fetcher in a Source) better. Instantiating a Fetcher directly from a source does not perform the useless serialization / deserialization steps anymore. The API is also now more consistent and therefore easier to learn. CMK-5450 Change-Id: I8d02fe363cb49a4ae3f3ce0df2fc6fdff7d4c813 Commit: e7090925128a56e12c7728bf036f43d1f46ffeb6 https://github.com/tribe29/checkmk/commit/e7090925128a56e12c7728bf036f43d1f… Author: Christian Haase <c.haase(a)ifu.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M docker/docker-entrypoint.sh Log Message: ----------- Abort docker-entrypoint script when a hook fails Change-Id: I24c8ed9c3959c8d2a9e1fffb5e9a964b15315cdc Commit: c23423a990ee13ceca611d7c0e87f696d51460c2 https://github.com/tribe29/checkmk/commit/c23423a990ee13ceca611d7c0e87f696d… Author: Christian Haase <c.haase(a)ifu.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M docker/docker-entrypoint.sh Log Message: ----------- Add very early docker-entrypoint hook Change-Id: I64e26b8e0751cd7fc85a7d46158b25e00ec57b6d Compare: https://github.com/tribe29/checkmk/compare/1fe5e400caeb...c23423a990ee