[checkmk-commits] [Checkmk/checkmk] 888893: skip old legacy check info elements

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 8888932a4329c0339a5660c83c8dc82f2702468e https://github.com/Checkmk/checkmk/commit/8888932a4329c0339a5660c83c8dc82f2… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M cmk/base/api/agent_based/register/check_plugins_legacy.py M cmk/base/config.py M cmk/utils/legacy_check_api.py M tests/testlib/__init__.py M tests/unit/checks/generictests/run.py M tests/unit/checks/test_generic_legacy_conversion.py M tests/unit/cmk/base/api/agent_based/register/test_check_plugins_legacy.py M tests/unit/cmk/base/test_config.py M tests/unit/cmk/snmplib/test_snmp_scan.py M tests/unit/conftest.py Log Message: ----------- skip old legacy check info elements Making the LegacyCheckDefinition a dataclass allows for a runtime instance check. This way we can filter out all plugins that are not in line with what ever this no-longer-stable, deprecated API chooses to accept, avoiding havoc during update config. Not loading local legacy checks at all is not an option, because there might be argument thingies in the files. Loading local legacy checks but then throwing away the new contents of the check_info is not very good, because it will prevent local "hot patches" of legacy plugins. Change-Id: I6ff6a50cff34f47adc453e9b4e186fb4d5606c1f Commit: 2f4a13bb7f5e25d8663edae21d9702415a8b8acf https://github.com/Checkmk/checkmk/commit/2f4a13bb7f5e25d8663edae21d9702415… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M cmk/gui/utils/rule_specs/legacy_converter.py M cmk/gui/validation/visitors/vue_formspec_visitor.py M packages/cmk-rulesets/cmk/rulesets/v1/form_specs/basic.py M tests/unit/cmk/gui/utils/rulespecs/test_legacy_converter.py Log Message: ----------- remove display precision from API Users should have the value presented to them as they entered it. For `display_format="%.2f"` the behavior of the legacy value specs is: 1) open form: users see default "0.00" 2) users enter "0.1234" and save: - "0.1234" is stored on disk - value is rendered as "0.12" in the UI 3) re-open form: users see "0.12" 4) save form: "0.12" is now stored on disk That's not ideal. Using "%r" makes python determine the desirable precision, without creating these weird cut-off effects. Change-Id: I09a20800e84b8ddae12c44d45c0a9ef8d2b769f9 Commit: 831b83e84fb8b9651a26c4a62572940f6955613a https://github.com/Checkmk/checkmk/commit/831b83e84fb8b9651a26c4a62572940f6… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Pipfile M Pipfile.lock M cmk/gui/openapi/restful_objects/specification.py Log Message: ----------- Bump apispec The dependency needs an update to get rid of the runtime depdendency on distutils and setuptools which has been removed from the projects dependencies with version 6.0.0. CMK-15978 Change-Id: Ic6b42ef223fe27da1213ebd2f104f2de900cd643 Compare: https://github.com/Checkmk/checkmk/compare/1a6383239354...831b83e84fb8