[checkmk-commits] [tribe29/checkmk] 3e8c13: transform: remove response_type from _request

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 3e8c1344c4027e6253614bb158109b2306fa3a6d https://github.com/tribe29/checkmk/commit/3e8c1344c4027e6253614bb158109b230… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-17 (Tue, 17 May 2022) Changed paths: M cmk/special_agents/utils_kubernetes/api_server.py Log Message: ----------- transform: remove response_type from _request This argument was incorrecly implemented and therefore call_api would always be called with response_type=str. Thus, the reponse_type would only serve as a way to set the typing for response. However, the assumption that call_api returns the type given by response_type is also incorrect. Example: If call_api is called with the argument `_preload_content=False`, then a urlib3 object is returned and not response_type. Since this argument serves no purpose, we remove the argument. Change-Id: I0a148184720c4faddb9f190e5ac887fa277987f2 Commit: 4df5dc3d9624f1bec0fb315fe1925a3419d73dab https://github.com/tribe29/checkmk/commit/4df5dc3d9624f1bec0fb315fe1925a341… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-17 (Tue, 17 May 2022) Changed paths: M cmk/special_agents/utils_kubernetes/api_server.py Log Message: ----------- transform: remove response_type from api_call The argument response_type=str causes api_call to return a str, which is consistent with the OpenAPI spec. However, this will invalidate any json data, which we obtain from an http request. Previously, we would use ast to deal with this issue. With the new arguments, api_call no longer uses the auto-generated code for parsing the http response. Instead, we implement our own parsing inside of RawAPI. Change-Id: Ib4f2f0c44df4edcf5dac7791404e656a99f7ca30 Commit: a885af0c37f1e165ed455917dadbf8ddcf0cb316 https://github.com/tribe29/checkmk/commit/a885af0c37f1e165ed455917dadbf8ddc… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-17 (Tue, 17 May 2022) Changed paths: A .werks/14126 M cmk/special_agents/utils_kubernetes/api_server.py M cmk/special_agents/utils_kubernetes/schemata/api.py M tests/unit/cmk/special_agents/utils_kubernetes/test_api_server.py Log Message: ----------- 14126 KUBE agent_kube: clarify error messages caused by unsupported Kubernetes version With this werk, the agent verifies whether the Kubernetes version is supported by Checkmk. If it is known that an API server with a certain version is incompatible, the agent will now provide a helpful error message. Different flavors of Kubernetes are not verified. In the event, that the version of the API server deviates from the versioning scheme used by Kubernetes, processing the API data is still attempted on a best effort basis. Errors related to unknown versioning schemes can be inspected by increasing the verbosity of the agent via the command line (you can find the command line tool by using cmk -D). CMK-10198 Change-Id: I398cf6e05b595873ab5f376788ec5f7d3c28065f Commit: 5fe6a19d2fcb01570a06b1570a9b494eacfcac02 https://github.com/tribe29/checkmk/commit/5fe6a19d2fcb01570a06b1570a9b494ea… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-17 (Tue, 17 May 2022) Changed paths: A .werks/14127 M cmk/special_agents/agent_kube.py Log Message: ----------- 14127 FIX KUBE agent_kube: Option Cluster resource aggregation matches inline help Previously, if the option 'Cluster resource aggregation' was used to exclude Nodes based on their roles, the performed search would be a prefix search. This was inconsistent with the inline help, which promises an infix search. With this werk, an infix search is now performed by the agent. Those users who have configured the option 'Cluster resource aggregation' to be sensitive to the type of regex matching performed need to verify that the agent is still performing as expected. Change-Id: Iaf5df0e4d44af82a1f47aaf83f2746c8c0679f85 Commit: 3e723f54373a183e22589e39d102b78c24a05054 https://github.com/tribe29/checkmk/commit/3e723f54373a183e22589e39d102b78c2… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-17 (Tue, 17 May 2022) Changed paths: A .werks/14128 M cmk/gui/plugins/wato/special_agents/kube.py M cmk/special_agents/agent_kube.py Log Message: ----------- 14128 FIX KUBE agent_kube: Option Monitor namespaces matches inline help Previously, if the option 'Monitor namespace' was used to filter namespaces, the performed search would be a prefix search. This was inconsistent with the inline help, which promises a complete search. With this werk, an infix search is now performed by the agent, which is the default in Checkmk. Those users who have configured the option 'Monitor namespaces' to be sensitive to the type of regex matching performed need to verify that the agent is still performing as expected. Change-Id: Ibc223a8c8498222b4fa802fe3b36fa3019b34319 Commit: 7060fcb86e84ff2246d05cd795ad7f16343401e2 https://github.com/tribe29/checkmk/commit/7060fcb86e84ff2246d05cd795ad7f163… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-05-17 (Tue, 17 May 2022) Changed paths: A .werks/14129 M cmk/base/plugins/agent_based/kube_pod_status.py Log Message: ----------- 14129 FIX KUBE kube_pod_status: Option Interpretation of pod status matches inline help Previously, if the option 'Interpretation of pod status' was used to assign a Pod to a group, the performed search would be a prefix search. This was inconsistent with the inline help, which promises an infix search. With this werk, an infix search is now performed by the agent. Those users who have configured the option 'Interpretation of pod status' to be sensitive to the type of regex matching performed need to verify that the agent is still performing as expected. Change-Id: I3a298e912554a11a8e1a59bdd8081330d9e27fbd Compare: https://github.com/tribe29/checkmk/compare/cf7f818bb489...7060fcb86e84