[checkmk-commits] [tribe29/checkmk] 5d663c: Updated tag renaming code docs; Minor naming fixes

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5d663c4dfefec942fec08c64dbf0a0ab9948e684 https://github.com/tribe29/checkmk/commit/5d663c4dfefec942fec08c64dbf0a0ab9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/gui/wato/pages/tags.py Log Message: ----------- Updated tag renaming code docs; Minor naming fixes Change-Id: Ic8209cd49aec56352443efd93d031bd1d8b9664d Commit: 4ad9eec851496cb97b32844335b04920da60cd6f https://github.com/tribe29/checkmk/commit/4ad9eec851496cb97b32844335b04920d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/gui/wato/pages/tags.py Log Message: ----------- Cleaned up redundant host/folder tag cleanup logic * The logic for the host and folder object tag attribute cleanup was duplicated. Is now centralized in _change_host_tags_in_host_or_folder(). * need_save variable has been removed to have less redundant information Change-Id: Ibf14cee1babfe63143fd804a89e4ac9434d0049a Commit: 4bc2cbcd119c7b495f07475f6a90b434d34b4acf https://github.com/tribe29/checkmk/commit/4bc2cbcd119c7b495f07475f6a90b434d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/gui/wato/pages/tags.py Log Message: ----------- Extract and restructure rule tag cleanup * Extract rule tag condition modification to dedicated function * Reduce nesting levels in that function Change-Id: I456a3f4ed8949fa5cfdc637d9601eb50fc9381ea Commit: 04768114321ca2374461296de9fa994f10284435 https://github.com/tribe29/checkmk/commit/04768114321ca2374461296de9fa994f1… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/gui/wato/pages/tags.py Log Message: ----------- Fix removing of whole tag groups This was not working since the switch to the new tag condition structure. Change-Id: I28d491100b642533fadc20a9fa8fa268b4dc584f Commit: 8345c2c407f3192fbf2da52a68ca5e4fabfcd0ff https://github.com/tribe29/checkmk/commit/8345c2c407f3192fbf2da52a68ca5e4fa… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/gui/wato/pages/tags.py Log Message: ----------- Fix removing or replacement of tag IDs This was not working since the switch to the new tag condition structure. Change-Id: I92891a4dc9568ab846f014da0a503376fb5c10a1 Commit: 5475a27dbc810b3ae1204c41341c4bce8580c21c https://github.com/tribe29/checkmk/commit/5475a27dbc810b3ae1204c41341c4bce8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/gui/wato/pages/tags.py Log Message: ----------- Minor simplification: Unify common condition Change-Id: I039f3216755d58df2774b0a2952c9f7dc48340e0 Commit: 36dd1f250fc45907af92bee7227b7042921384e0 https://github.com/tribe29/checkmk/commit/36dd1f250fc45907af92bee7227b70429… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/gui/wato/pages/tags.py Log Message: ----------- Cleanup tag rename operations * Instead of the previous duck typing and implicit conventions the operations are now cleanly represented as objects of type ABCOperation. * The tags to be replaced/removed are now kept in separate data structures for more clarity. Change-Id: I00e877a63dd5d64fd3a4e1be09f2c1f86f746b4b Commit: 79121c5f3751a06495938b1e1cac4ba1d403b291 https://github.com/tribe29/checkmk/commit/79121c5f3751a06495938b1e1cac4ba1d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/utils/rulesets/ruleset_matcher.py M tests/unit/cmk_base/test_config.py Log Message: ----------- Remove dead code Change-Id: I9718bb33e1a6c9b24f7ce4004b6d6d093fd425b9 Commit: c1313f02a5ad640f52f48f732fb438cf9ae6ac22 https://github.com/tribe29/checkmk/commit/c1313f02a5ad640f52f48f732fb438cf9… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/utils/werks.py Log Message: ----------- Cleanup obsolete comment (The code is not duplicated anymore) Change-Id: I8237e72d55e459c9a43b5d6a5905c841be1fd468 Commit: aabee7427e33d09fc5f0cd6bf607f8630be915db https://github.com/tribe29/checkmk/commit/aabee7427e33d09fc5f0cd6bf607f8630… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: 2019-06-03 (Mon, 03 Jun 2019) Changed paths: M cmk/ec/main.py M cmk/utils/daemon.py M tests/unit/cmk/utils/test_daemon.py Log Message: ----------- Spread some pathlib usage Change-Id: I875a47fd53901d239636d9c167113122b88778bd Compare: https://github.com/tribe29/checkmk/compare/9e2ab1b6e731...aabee7427e33