[checkmk-commits] 3662 FIX Fixed creation/editing of dashboards (regression since 1.2.8p5)

Module: check_mk Branch: master Commit: 4fdbb1443dd00bd001a1f5a188ec6053165eff98 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4fdbb1443dd00b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jul 6 10:39:16 2016 +0200 3662 FIX Fixed creation/editing of dashboards (regression since 1.2.8p5) --- .werks/3662 | 10 ++++++++++ ChangeLog | 1 + web/htdocs/visuals.py | 5 +++-- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/.werks/3662 b/.werks/3662 new file mode 100644 index 0000000..b38ba34 --- /dev/null +++ b/.werks/3662 @@ -0,0 +1,10 @@ +Title: Fixed creation/editing of dashboards (regression since 1.2.8p5) +Level: 1 +Component: multisite +Class: fix +Compatible: compat +State: unknown +Version: 1.4.0i1 +Date: 1467794282 + + diff --git a/ChangeLog b/ChangeLog index 1da175c..c37e37c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -383,6 +383,7 @@ * 2239 FIX: Fixed exception in WATO snapins Folders, Tree of folders and Virtual Host Tree... * 3148 FIX: fixed Edit View/Dashlet Dialogs offering non-sensical filter choices... * 3659 FIX: Fixed GUI exceptions for users having special characters in ther user names + * 3662 FIX: Fixed creation/editing of dashboards (regression since 1.2.8p5) WATO: * 3244 WATO BI Module: swap order of aggregation function and child node selection... diff --git a/web/htdocs/visuals.py b/web/htdocs/visuals.py index b21e795..66ba942 100644 --- a/web/htdocs/visuals.py +++ b/web/htdocs/visuals.py @@ -520,7 +520,7 @@ def get_context_specs(visual, info_handler): filter_names = filter_list.filter_names() if not filter_names: - return [] # Skip infos which have no filters available + return # Skip infos which have no filters available params = [ ('filters', filter_list), @@ -533,7 +533,8 @@ def get_context_specs(visual, info_handler): # single infos first, the rest afterwards return [(info_key, visual_spec_single(info_key)) for info_key in single_info_keys] +\ - [(info_key, visual_spec_multi(info_key)) for info_key in multi_info_keys] + [(info_key, visual_spec_multi(info_key)) for info_key in multi_info_keys + if visual_spec_multi(info_key) ] def process_context_specs(context_specs):