[checkmk-commits] [tribe29/checkmk] 5467b4: 10410 brocade_fcport: use 64bit counters for tx/rx...

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5467b445a2429c841276c5ff5c94821734dcbe45 https://github.com/tribe29/checkmk/commit/5467b445a2429c841276c5ff5c9482173… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-11-21 (Thu, 21 Nov 2019) Changed paths: A .werks/10410 M checks/brocade_fcport A tests/unit/checks/generictests/datasets/brocade_regression.py Log Message: ----------- 10410 brocade_fcport: use 64bit counters for tx/rx frames On high-speed interfaces, the 32bit counters may wrap very often and make the counters unusable. 64bit counters track traffic appropriately, thus they are preferred when available. The 64bit counters are already used for tx/rx words and bbcredits CMK-3188 Close #72 Change-Id: I0ce1dad3fcda2e7470ad887b02df55d1603b7464 Commit: a430ca3f17f1fdbc9b2d8bbbf68f332ec4fbe520 https://github.com/tribe29/checkmk/commit/a430ca3f17f1fdbc9b2d8bbbf68f332ec… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-11-21 (Thu, 21 Nov 2019) Changed paths: M checks/brocade_fcport Log Message: ----------- Brocade_port: Fix priority in if_table for recognizing speed Brocade speed :swFCPortSpeed is deprecated in firmware 7.2.1 as for comment is check. But we only select the new speed value for fibre channel. The if_table had a if clause in the list comprehension with wrong operator priority. Brocade speed maps from a dictionary with integer keys, it never recognizes str values. It was priority, but now that is fixed we need to skip that return for the fibre channel new speed. CMK-3187 Change-Id: Iac998edfb420742b9ecbeb149e62bf6754b1267b Compare: https://github.com/tribe29/checkmk/compare/9106de47da7e...a430ca3f17f1