Module: check_mk
Branch: master
Commit: d2905739dfa133ef85d8661bee660ed19cac7b8f
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d2905739dfa133…
Author: Andreas Boesl <ab(a)mathias-kettner.de>
Date: Mon Apr 7 14:47:25 2014 +0200
FIX df: fixed problems on some filesystem checks when legacy check parameters where used
Any checks using the df.include library function had problems when their
check parameters where configured in a legacy syntax - in detail tuple(int, int)
This caused invalid output from Agent messages. However, a reinventory
of the check in question fixed the problems.
---
.werks/787 | 11 +++++++++++
ChangeLog | 1 +
checks/df.include | 2 +-
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/.werks/787 b/.werks/787
new file mode 100644
index 0000000..23285a7
--- /dev/null
+++ b/.werks/787
@@ -0,0 +1,11 @@
+Title: df: fixed problems on some filesystem checks when legacy check parameters where
used
+Level: 1
+Component: checks
+Version: 1.2.5i3
+Date: 1396874528
+Class: fix
+
+Any checks using the df.include library function had problems when their
+check parameters where configured in a legacy syntax - in detail tuple(int, int)
+This caused invalid output from Agent messages. However, a reinventory
+of the check in question fixed the problems.
diff --git a/ChangeLog b/ChangeLog
index a2f5784..8f140be 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -18,6 +18,7 @@
* 0777 FIX: special agent emcvnx: did not work with security file authentication...
* 0786 FIX: zfsget: fixed compatibility with older Solaris agents...
* 0809 FIX: brocade_fcport: Fixed recently introduced problem with port speed
detection
+ * 0787 FIX: df: fixed problems on some filesystem checks when legacy check parameters
where used...
Multisite:
* 0779 Hostgroups (Summary): Empty hostgroups are no longer shown (can be re-enabled
by filter)
diff --git a/checks/df.include b/checks/df.include
index 987bf59..6f8a7a7 100644
--- a/checks/df.include
+++ b/checks/df.include
@@ -215,7 +215,7 @@ def get_filesystem_levels(host, mountpoint, size_gb, params):
crit_hr = get_bytes_human_readable(crit * mega)
levels["levels_text"] = "(%s %s/%s)" % (label, warn_hr,
crit_hr)
- if params.get("inodes_levels"):
+ if "inodes_levels" in params:
if type(levels["inodes_levels"]) == tuple:
warn, crit = levels["inodes_levels"]
else: