[checkmk-commits] [tribe29/checkmk] b819b3: Removed dead definitions

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b819b36560fba9e298cacf5296d2f3217f5322ec https://github.com/tribe29/checkmk/commit/b819b36560fba9e298cacf5296d2f3217… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-11-10 (Wed, 10 Nov 2021) Changed paths: M cmk/gui/plugins/metrics/network.py M cmk/gui/plugins/metrics/storage.py Log Message: ----------- Removed dead definitions legend_precision and legend_scale are not used by the metric system. Change-Id: I0743c8c233e1e2f00eb973f7fc8b28610a562388 Commit: 1dd5b18a711dd7ce8e8fbc3c9f9a033131043580 https://github.com/tribe29/checkmk/commit/1dd5b18a711dd7ce8e8fbc3c9f9a03313… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-11-10 (Wed, 10 Nov 2021) Changed paths: M cmk/gui/plugins/metrics/oracle.py Log Message: ----------- Fix wrong metric definitions These wrong declarations were uncovered by the just added type hints. Change-Id: Ic24d09c7cbaeb80e599850a4046f645445893659 Commit: d511d1a05d723b1f6c71ecf0790f1ded2bf9b0e8 https://github.com/tribe29/checkmk/commit/d511d1a05d723b1f6c71ecf0790f1ded2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-11-10 (Wed, 10 Nov 2021) Changed paths: M cmk/gui/plugins/dashboard/graph.py M cmk/gui/plugins/metrics/__init__.py M cmk/gui/plugins/metrics/graph_templates.py M cmk/gui/plugins/metrics/network.py M cmk/gui/plugins/metrics/utils.py M cmk/gui/type_defs.py M tests/unit/cmk/gui/plugins/metrics/test_graph_templates.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_graph_template.py Log Message: ----------- Metric system: Improve type hints Some localizations in our GUI plugins needed to be converted to lazy localized strings now that we are loading our GUI plugins earlier. These strings are now wrapped by the LazyString objects for the translation to happen later. To make it work, the LazyString objects now need to be transformed to str in the moment they are used. During these changes some issues were found by the integration tests and later during manual tests. This commit adds the type hints which would have uncovered these issues. We add several other type hints along the way. This commit also includes some minor necessary simplifications which were needed to make mypy understand the situation. Change-Id: Ia224da080da12c6310e538721de882a9501612bd Compare: https://github.com/tribe29/checkmk/compare/dd03bceca6f4...d511d1a05d72