[checkmk-commits] Check_MK Git: check_mk: #2069 FIX netapp_api_disk.summary:

fixed one missing disk in summary check Message-ID: <55362f2d./0meDl98TeXyJVhp%ab(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: 56131db24a03a402e4793ef0cc401f39eb456ff1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=56131db24a03a4… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Apr 21 13:05:45 2015 +0200 #2069 FIX netapp_api_disk.summary: fixed one missing disk in summary check The library function responsible for parsing the agent data did omit the last disk entry, thus leading to an invalid disk count and possibly missing error data. --- .werks/2069 | 11 +++++++++++ ChangeLog | 2 ++ checks/netapp_api.include | 2 ++ 3 files changed, 15 insertions(+) diff --git a/.werks/2069 b/.werks/2069 new file mode 100644 index 0000000..b3f569b --- /dev/null +++ b/.werks/2069 @@ -0,0 +1,11 @@ +Title: netapp_api_disk.summary: fixed one missing disk in summary check +Level: 1 +Component: checks +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i1 +Date: 1429614114 + +The library function responsible for parsing the agent data did omit the last +disk entry, thus leading to an invalid disk count and possibly missing error data. diff --git a/ChangeLog b/ChangeLog index 10eceb9..029cd37 100644 --- a/ChangeLog +++ b/ChangeLog @@ -335,6 +335,7 @@ * 2067 FIX: windows agent: product version is no longer set to 1.0.0... * 2068 FIX: Filesystem checks: Fix crash when legacy parameters (tuple) were used... * 2213 FIX: cisco_temperature: Fixed behaviour in cases where device reports status but no temperature... + * 2069 FIX: netapp_api_disk.summary: fixed one missing disk in summary check... Multisite: * 1758 Improved exception hander: Shows details without additional debug request, added mailto link for error report... @@ -460,6 +461,7 @@ * 1662 notification plugin spectrum: finalized script. now able to handle host notications * 1213 New Notification macros $SERVICEFORURL$ and $HOSTFORURL$... * 2041 Notification Spooler can now handle incoming and outgoing persistent TCP connections... + NOTE: Please refer to the migration notes! * 2135 Allow to filter notification contacts based on values of custom macros... * 1235 Added notification plugin for Braintower SMS Gateways... * 2188 Rule based notification now allow match for notification comment... diff --git a/checks/netapp_api.include b/checks/netapp_api.include index c77914a..d1926f6 100644 --- a/checks/netapp_api.include +++ b/checks/netapp_api.include @@ -88,6 +88,7 @@ def netapp_api_convert_info(info, configs = {}, counter_key = None, counter_as_k while True: line = lines.next() if line[0] == "[config_instance]": + add_config() add_counter() current_counter = {} is_config = True @@ -95,6 +96,7 @@ def netapp_api_convert_info(info, configs = {}, counter_key = None, counter_as_k continue elif line[0] == "[counter_instance]": add_config() + add_counter() current_config = {} is_config = False continue