5 Nov
2015
5 Nov
'15
9:59 a.m.
Module: check_mk
Branch: master
Commit: 220ddeb7e6ae30d7ffa76c40af217a8184819e64
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=220ddeb7e6ae30…
Author: Sven Panne <sp(a)mathias-kettner.de>
Date: Thu Nov 5 10:51:10 2015 +0100
Using "using namespace FOO" in headers is a big no-no.
Just to save a few keystrokes, doing this introduces several maintenance
problems: By including a header, one can get unexpected name clashes. Even
worse: By adding an include, one can silently change the *meaning* of a
program, because the compiler might pick a better match for a function
candidate. So "using namespace" in headers is considered an anti-pattern,
and even using it in implementation files is very contraversial.
For more background, see Herb Sutter's article "Migrating to Namespaces":
http://www.gotw.ca/publications/migrating_to_namespaces.htm
---
livestatus/src/AndingFilter.h | 2 +-
livestatus/src/AttributelistColumn.cc | 4 +--
livestatus/src/AttributelistColumn.h | 4 +--
livestatus/src/BlobColumn.h | 2 +-
livestatus/src/ClientQueue.h | 3 +-
livestatus/src/Column.cc | 2 +-
livestatus/src/Column.h | 9 +++--
livestatus/src/ColumnsColumn.h | 2 +-
livestatus/src/ContactgroupsColumn.h | 2 +-
livestatus/src/ContactgroupsMemberColumn.h | 2 +-
livestatus/src/ContactsColumn.h | 2 +-
livestatus/src/CustomTimeperiodColumn.h | 4 +--
livestatus/src/CustomVarsColumn.h | 4 +--
livestatus/src/CustomVarsExplicitColumn.h | 4 +--
livestatus/src/CustomVarsFilter.h | 6 ++--
livestatus/src/DoubleColumn.cc | 2 +-
livestatus/src/DoubleColumn.h | 4 +--
livestatus/src/DoubleColumnFilter.h | 1 -
livestatus/src/DownCommColumn.cc | 4 +--
livestatus/src/DownCommColumn.h | 2 +-
livestatus/src/DowntimeOrComment.h | 1 -
livestatus/src/DynamicColumn.h | 7 ++--
livestatus/src/EmptyColumn.h | 2 +-
livestatus/src/Filter.h | 5 ++-
livestatus/src/FixedIntColumn.h | 2 +-
livestatus/src/GlobalCountersColumn.h | 2 +-
livestatus/src/HostContactsColumn.h | 2 +-
livestatus/src/HostFileColumn.cc | 2 +-
livestatus/src/HostFileColumn.h | 6 ++--
livestatus/src/HostServiceState.h | 3 +-
livestatus/src/HostSpecialDoubleColumn.h | 2 +-
livestatus/src/HostSpecialIntColumn.h | 2 +-
livestatus/src/HostgroupsColumn.h | 2 +-
livestatus/src/HostlistColumn.h | 2 +-
livestatus/src/HostlistColumnFilter.h | 3 +-
livestatus/src/HostlistStateColumn.h | 2 +-
livestatus/src/InputBuffer.cc | 6 ++--
livestatus/src/InputBuffer.h | 5 ++-
livestatus/src/IntColumn.cc | 2 +-
livestatus/src/IntColumn.h | 4 +--
livestatus/src/IntColumnFilter.h | 3 +-
livestatus/src/IntPointerColumn.h | 2 +-
livestatus/src/ListColumn.h | 2 +-
livestatus/src/LogCache.cc | 2 +-
livestatus/src/LogCache.h | 2 +-
livestatus/src/Logfile.cc | 2 +-
livestatus/src/Logfile.h | 4 +--
livestatus/src/MetricsColumn.h | 2 +-
livestatus/src/NullColumn.h | 2 +-
livestatus/src/OffsetDoubleColumn.h | 2 +-
livestatus/src/OffsetIntColumn.h | 2 +-
livestatus/src/OffsetStringColumn.h | 2 +-
livestatus/src/OffsetStringHostMacroColumn.h | 2 +-
livestatus/src/OffsetStringMacroColumn.cc | 12 +++----
livestatus/src/OffsetStringMacroColumn.h | 4 +--
livestatus/src/OffsetStringServiceMacroColumn.h | 2 +-
livestatus/src/OffsetTimeColumn.h | 2 +-
livestatus/src/OffsetTimeperiodColumn.cc | 2 +-
livestatus/src/OffsetTimeperiodColumn.h | 2 +-
livestatus/src/OutputBuffer.h | 3 +-
livestatus/src/PerfdataAggregator.cc | 2 +-
livestatus/src/Query.cc | 10 +++---
livestatus/src/Query.h | 17 +++++-----
livestatus/src/ServiceContactsColumn.h | 2 +-
livestatus/src/ServiceSpecialDoubleColumn.h | 2 +-
livestatus/src/ServiceSpecialIntColumn.h | 2 +-
livestatus/src/ServicegroupsColumn.h | 2 +-
livestatus/src/ServicelistColumn.h | 2 +-
livestatus/src/ServicelistColumnFilter.cc | 2 +-
livestatus/src/ServicelistColumnFilter.h | 5 ++-
livestatus/src/ServicelistStateColumn.h | 2 +-
livestatus/src/StatusSpecialIntColumn.h | 2 +-
livestatus/src/Store.cc | 38 ++++++++++-----------
livestatus/src/Store.h | 4 +--
livestatus/src/StringColumn.h | 4 +--
livestatus/src/StringColumnFilter.h | 4 +--
livestatus/src/StringPointerColumn.h | 2 +-
livestatus/src/Table.cc | 10 +++---
livestatus/src/Table.h | 5 ++-
livestatus/src/TableColumns.h | 2 +-
livestatus/src/TableCommands.cc | 2 +-
livestatus/src/TableCommands.h | 2 +-
livestatus/src/TableContactgroups.cc | 2 +-
livestatus/src/TableContactgroups.h | 2 +-
livestatus/src/TableContacts.cc | 4 +--
livestatus/src/TableContacts.h | 2 +-
livestatus/src/TableDownComm.cc | 6 ++--
livestatus/src/TableDownComm.h | 5 ++-
livestatus/src/TableHostgroups.cc | 2 +-
livestatus/src/TableHostgroups.h | 2 +-
livestatus/src/TableHosts.cc | 2 +-
livestatus/src/TableHosts.h | 2 +-
livestatus/src/TableLog.cc | 4 +--
livestatus/src/TableLog.h | 2 +-
livestatus/src/TableServicegroups.cc | 2 +-
livestatus/src/TableServicegroups.h | 2 +-
livestatus/src/TableServices.cc | 2 +-
livestatus/src/TableServices.h | 3 +-
livestatus/src/TableStateHistory.cc | 10 +++---
livestatus/src/TableStateHistory.h | 2 +-
livestatus/src/TableTimeperiods.cc | 2 +-
livestatus/src/TableTimeperiods.h | 2 +-
livestatus/src/TimePointerColumn.h | 2 +-
livestatus/src/pnp4nagios.cc | 41 +++++++++++------------
livestatus/src/store_c.cc | 2 --
105 files changed, 190 insertions(+), 221 deletions(-)
Diff:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=220ddeb7e6…