[checkmk-commits] [Checkmk/checkmk] 729572: Let mypy check all of _validate_parse_function(). ...

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 72957291af3cf1fb9db27e54da2e19c74701c2df https://github.com/Checkmk/checkmk/commit/72957291af3cf1fb9db27e54da2e19c74… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2023-09-06 (Wed, 06 Sep 2023) Changed paths: M cmk/base/api/agent_based/register/section_plugins.py Log Message: ----------- Let mypy check all of _validate_parse_function(). Comments. Mypy thinks that a parse_function can *never* be a types.FunctionType, so it considers most of _validate_parse_function() unreachable code, effectively disabling type checking it. This is due to the type of the parse_function argument (effectively a union of Callables) and the implementation of types.FunctionType plus a few ugly technical details. We circumvent this by calling inspect.isfunction(), which does the same, but this is hidden from mypy. :-} In any case, we probably just want to check for callable(), but this would be a separate change. CMK-14437 Change-Id: Ia403b3f062459c60a8c9c6841533800fbe69f79c Commit: 54dbd027d52ee6ac343cc6aad87ac737e991c6a0 https://github.com/Checkmk/checkmk/commit/54dbd027d52ee6ac343cc6aad87ac737e… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2023-09-06 (Wed, 06 Sep 2023) Changed paths: M cmk/base/api/agent_based/register/section_plugins.py M tests/unit/cmk/base/api/agent_based/register/test_section_plugins.py M tests/unit/cmk/base/api/agent_based/register/test_section_plugins_legacy.py Log Message: ----------- Potentially allow more than one annotation for string_table. No functional change, the set of expected annotations is just a singleton set now instead of a single value. This is a preparatory change to allow more than one annotation in the future commits, e.g. list *and* List. CMK-14437 Change-Id: Ib1d69445b90778d1b44cbe53327d100d4ddc67fb Compare: https://github.com/Checkmk/checkmk/compare/b8f9da9cf7bf...54dbd027d52e