[checkmk-commits] [Checkmk/checkmk] 47e7c1: snmp_modes: inline users

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 47e7c16841f2b36f0e92709823d5778355c0f79f https://github.com/Checkmk/checkmk/commit/47e7c16841f2b36f0e92709823d577835… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2023-07-20 (Thu, 20 Jul 2023) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/modes/check_mk.py M cmk/snmplib/snmp_modes.py M tests/integration/cmk/lib/snmplib/helper_walk_for_export.py Log Message: ----------- snmp_modes: inline users The goal is to separate the actual library functions, that is, the functions that are reused from their users. This clarifies the layering, simplifies the users (less unnecessary indirections). This also improves the possibility to maintain both sides (library + users) by reducing and clarifying the scope of the functions. Change-Id: I05d34229587b563fbc21416257ba5b6fafbd21ca Commit: d6ece4e402e331fb01a754f5bf676724eb3665ad https://github.com/Checkmk/checkmk/commit/d6ece4e402e331fb01a754f5bf676724e… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2023-07-20 (Thu, 20 Jul 2023) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/modes/check_mk.py M cmk/fetchers/_snmpscan.py M cmk/snmplib/__init__.py A cmk/snmplib/_getoid.py A cmk/snmplib/_walk.py R cmk/snmplib/snmp_modes.py M tests/integration/cmk/lib/snmplib/helper_get_single_oid.py M tests/integration/cmk/lib/snmplib/helper_walk_for_export.py M tests/integration/cmk/lib/snmplib/test_snmp_modes.py Log Message: ----------- Split and rename `snmp_modes` `snmp_modes` only makes sense if considering the *users*... and even then, it's wrong because of `automations`. Also: flatten, `snmplib` is just about 5 functions and a few types. Flat is good enough. Change-Id: I321d73009087fd59af1da5f13c4d6c2014d80224 Compare: https://github.com/Checkmk/checkmk/compare/8a9d318207c2...d6ece4e402e3