[checkmk-commits] [Checkmk/checkmk] f13319: cisco prime: migrate special agent to SSC API

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: f13319de146261376f4b73d30fc0bad5c7bdcf1c https://github.com/Checkmk/checkmk/commit/f13319de146261376f4b73d30fc0bad5c… Author: Sofia Colakovic <sofia.colakovic(a)checkmk.com> Date: 2024-02-28 (Wed, 28 Feb 2024) Changed paths: R cmk/base/legacy_checks/agent_cisco_prime.py A cmk/plugins/cisco/server_side_calls/prime.py R tests/unit/checks/test_agent_cisco_prime.py A tests/unit/cmk/plugins/cisco/server_side_calls/test_prime.py M tests/unit/cmk/plugins_consistency/test_special_agent_args.py Log Message: ----------- cisco prime: migrate special agent to SSC API Change-Id: I14d28f9fa2b12279e2282c7c753b5df384f333de Commit: 29bc5cb6b8660594e11be6fb315ec870b6bd303f https://github.com/Checkmk/checkmk/commit/29bc5cb6b8660594e11be6fb315ec870b… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2024-02-28 (Wed, 28 Feb 2024) Changed paths: M cmk/base/server_side_calls/_active_checks.py M cmk/base/server_side_calls/_special_agents.py M cmk/plugins/collection/server_side_calls/agent_bi.py M cmk/plugins/collection/server_side_calls/http.py M cmk/plugins/elasticsearch/server_side_calls/special_agent.py M cmk/plugins/prism/server_side_calls/special_agent.py M packages/cmk-server-side-calls/cmk/server_side_calls/v1/_active_checks.py M packages/cmk-server-side-calls/cmk/server_side_calls/v1/_special_agents.py M packages/cmk-server-side-calls/cmk/server_side_calls/v1/_utils.py M packages/cmk-server-side-calls/tests/v1/test_utils.py M tests/unit/cmk/base/test_server_side_calls.py M tests/unit/cmk/plugins/aws/server_side_calls/test_aws.py M tests/unit/cmk/plugins/collection/server_side_calls/test_bi_aggr.py M tests/unit/cmk/plugins/collection/server_side_calls/test_check_sftp.py M tests/unit/cmk/plugins/collection/server_side_calls/test_check_uniserv.py M tests/unit/cmk/plugins/collection/server_side_calls/test_cisco_meraki.py M tests/unit/cmk/plugins/collection/server_side_calls/test_datadog.py M tests/unit/cmk/plugins/collection/server_side_calls/test_icmp.py M tests/unit/cmk/plugins/collection/server_side_calls/test_kube.py M tests/unit/cmk/plugins/elasticsearch/server_side_calls/test_agent_elasticsearch.py M tests/unit/cmk/plugins/fritzbox/server_side_calls/test_agent_fritzbox.py M tests/unit/cmk/plugins/proxmox_ve/server_side_calls/test_special_agent.py M tests/unit/cmk/plugins/pure_storage_fa/server_side_calls/test_special_agent.py M tests/unit/cmk/plugins/three_par/server_side_calls/test_three_par.py Log Message: ----------- Make the SSC dataclass constructors kw_only. Allowing the passing of up to 11 parameters by position would be insane, especially with the primtive obsession going on here, i.e. most of the parameters have type str or Mapping[str, str]: Swapping parameters would go unnoticed without any static tool complaining. So let's at least make the call sites more explicit about what primitive entity is passed for which purpose. Change-Id: Idff0e39fcf341683995da5844abfd79bfbc854e9 Compare: https://github.com/Checkmk/checkmk/compare/0f86460bcecc...29bc5cb6b866 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications