[checkmk-commits] 7115 FIX stormshield.include: Fixed possible performance losses

Module: check_mk Branch: master Commit: 92f10789f01a236053d47a2ebf71945d44769e1a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=92f10789f01a23… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Mar 5 14:16:04 2019 +0100 7115 FIX stormshield.include: Fixed possible performance losses Change-Id: I6a365d85632aafb7e87d2baef70b6a7d05f6c15a --- .werks/7115 | 20 ++++++++++++++++++++ checks/stormshield.include | 5 ++--- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/.werks/7115 b/.werks/7115 new file mode 100644 index 0000000..a1fd940 --- /dev/null +++ b/.werks/7115 @@ -0,0 +1,20 @@ +Title: stormshield.include: Fixed possible performance losses +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.6.0i1 +Date: 1551791544 +Class: fix + +SNMP scan functions have the task to filter out SNMP hosts +for which it's not worth trying to discover related services. + +In order to achieve this every scan function tries +to find out the right device type by reference to +SNMP SysObjID and/or SNMP SysDescr. + +The stormshield scan functions were not restrictive enough and +the result was that for every SNMP host the SNMP table +below .1.3.6.1.4.1.11256 was requested. This might led to +losses during service discovery of all SNMP devices. diff --git a/checks/stormshield.include b/checks/stormshield.include index 7e2dd48..6b2e4c9 100644 --- a/checks/stormshield.include +++ b/checks/stormshield.include @@ -24,8 +24,7 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. -# example output - def stormshield_scan_function(oid): - return oid('.1.3.6.1.4.1.11256.1.0.1.0') + return (oid(".1.3.6.1.2.1.1.2.0").startswith('.1.3.6.1.4.1.8072') and + oid('.1.3.6.1.4.1.11256.1.0.1.0'))