[checkmk-commits] [tribe29/checkmk] a03b12: snmp_scan: Add whitebox testing

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a03b12c2278ce82df06e77b2dcb07420c26e7e80 https://github.com/tribe29/checkmk/commit/a03b12c2278ce82df06e77b2dcb07420c… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-18 (Thu, 18 Jun 2020) Changed paths: M cmk/base/snmp_scan.py M tests-py3/unit/cmk/base/test_snmp_scan.py Log Message: ----------- snmp_scan: Add whitebox testing We cannot split huge functions without tests and we cannot properly test huge functions. We are lucky enough that whitebox testing is at all possible. This is not meant to stay this way. CMK-4766 Change-Id: I5c3e94ea504fa718c0350dda7bbfd6481c5f7aed Commit: bfb67bf4cd76f347ae4fc8dffbd2553cb328c300 https://github.com/tribe29/checkmk/commit/bfb67bf4cd76f347ae4fc8dffbd2553cb… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-18 (Thu, 18 Jun 2020) Changed paths: M cmk/base/data_sources/snmp.py M cmk/base/snmp_scan.py M tests-py3/unit/cmk/base/test_snmp_scan.py Log Message: ----------- snmp_scan: Refactoring #1 split function CMK-4766 Change-Id: Ib945a8963d1f9983b79d6c2fc87ff1fdd1ce81cf Commit: f748bd2f61e083a3e1e1f9f6e3e04a9342c75916 https://github.com/tribe29/checkmk/commit/f748bd2f61e083a3e1e1f9f6e3e04a934… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-18 (Thu, 18 Jun 2020) Changed paths: M cmk/base/data_sources/snmp.py M cmk/base/discovery.py M cmk/base/inventory.py M cmk/base/snmp_scan.py M tests-py3/unit/cmk/base/data_sources/test_snmp_data_source.py M tests-py3/unit/cmk/base/test_snmp_scan.py Log Message: ----------- snmp_scan: Refactoring #2 - pass sections later The list of sections is computed as late as possible, that is, in the CachedSNMPDetector. The scan function does not need to know whether the caller is discovery or inventory. It only needs the corresponding SNMPSectionPlugin iterable. This removes more deps of snmp_scan on base. We can now unit test the module. CMK-4766 Change-Id: I0df39233aae36a1944b831abddd421e358929832 Commit: 7b94f97e7052fa8f110de9e5648f79426e7c8c94 https://github.com/tribe29/checkmk/commit/7b94f97e7052fa8f110de9e5648f79426… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-18 (Thu, 18 Jun 2020) Changed paths: M cmk/base/data_sources/snmp.py M cmk/base/snmp_scan.py M tests-py3/unit/cmk/base/data_sources/test_snmp_data_source.py M tests-py3/unit/cmk/base/test_snmp_scan.py Log Message: ----------- snmp_scan: Remove deps on `cmk.base.config` - The caller now takes care of flagging for inventory/discovery. - Perform the filtering using the management board separately after the call to `gather_...`. CMK-4766 Change-Id: I257d71c7572a8b8150e281b379e47e63f7cb9a9e Commit: 1816b787c3329614bea0e3d4d76f5a6273b8ae11 https://github.com/tribe29/checkmk/commit/1816b787c3329614bea0e3d4d76f5a627… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-18 (Thu, 18 Jun 2020) Changed paths: M cmk/base/api/__init__.py M cmk/base/api/agent_based/checking_types.py M cmk/base/api/agent_based/register/check_plugins.py M cmk/base/api/agent_based/register/check_plugins_legacy.py M cmk/base/api/agent_based/register/section_plugins.py M cmk/base/api/agent_based/section_types.py M cmk/base/api/agent_based/value_store.py M cmk/base/check_api.py M cmk/base/check_table.py M cmk/base/checking.py M cmk/base/config.py M cmk/base/data_sources/__init__.py M cmk/base/data_sources/abstract.py M cmk/base/data_sources/host_sections.py M cmk/base/data_sources/ipmi.py M cmk/base/data_sources/piggyback.py M cmk/base/data_sources/programs.py M cmk/base/data_sources/snmp.py M cmk/base/data_sources/tcp.py M cmk/base/discovery.py M cmk/base/inventory.py M cmk/base/inventory_plugins.py M cmk/utils/type_defs.py M tests-py3/unit/checks/test_generic_legacy_conversion.py M tests-py3/unit/cmk/base/api/agent_based/register/test_check_plugins.py M tests-py3/unit/cmk/base/api/agent_based/register/test_check_plugins_legacy.py M tests-py3/unit/cmk/base/api/agent_based/register/test_section_plugins.py M tests-py3/unit/cmk/base/api/agent_based/register/test_section_plugins_legacy.py M tests-py3/unit/cmk/base/api/agent_based/test_utils_value_store.py R tests-py3/unit/cmk/base/api/test_plugin_name.py M tests-py3/unit/cmk/base/data_sources/test_host_sections.py M tests-py3/unit/cmk/base/test_config.py A tests-py3/unit/cmk/utils/test_type_defs_plugin_name.py Log Message: ----------- Define PluginName in `cmk.utils.type_defs` We need `PluginName` in `snmp_scan`, which is on a lower abstraction level than the API. CMK-4766 Change-Id: I5144def9e669b19021b8574696c6de37aab5320a Commit: d6affa568c609730d4a98f46e9a2dd2f0af762a8 https://github.com/tribe29/checkmk/commit/d6affa568c609730d4a98f46e9a2dd2f0… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-18 (Thu, 18 Jun 2020) Changed paths: M cmk/base/data_sources/snmp.py M cmk/base/snmp_scan.py M tests-py3/unit/cmk/base/test_snmp_scan.py Log Message: ----------- Remove last dep of `snmp_scan` on higher layers CMK-4766 Change-Id: I03299c1ef8121406d1e9d9a942440ab9cf06c1c2 Commit: 686c636b0a8c31fffcc32732d7b54a8fe078deab https://github.com/tribe29/checkmk/commit/686c636b0a8c31fffcc32732d7b54a8fe… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-06-18 (Thu, 18 Jun 2020) Changed paths: M cmk/base/data_sources/snmp.py M cmk/base/discovery.py M cmk/base/inventory.py R cmk/base/snmp_scan.py A cmk/snmplib/snmp_scan.py R tests-py3/unit/cmk/base/test_snmp_scan.py A tests-py3/unit/cmk/lib/test_snmplib_snmp_scan.py Log Message: ----------- Move snmp_table to snmplib It is another SNMP module used as a library in base. So it makes sense to move it to a lower abstraction layer than base. CMK-4766 Change-Id: Id38ee1a1c2891ebe44faca5fc92ff6f659f58d20 Compare: https://github.com/tribe29/checkmk/compare/f334759561b8...686c636b0a8c