[checkmk-commits] [Checkmk/checkmk] 759234: 16781 FIX Bi: service/host_label group operator no...

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 759234a1509c3ebd99770b927f3bdfda85a0cc5e https://github.com/Checkmk/checkmk/commit/759234a1509c3ebd99770b927f3bdfda8… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: A .werks/16781.md M cmk/bi/search.py M tests/unit/cmk/gui/openapi/test_openapi_bi.py Log Message: ----------- 16781 FIX Bi: service/host_label group operator now has a default operator key "and" When creating Bi rules via the REST-API, the host_label_groups and the service_label_groups fields both accepted a list of conditions. These conditions previously required an operator field. However, we realized that the operator field for the first item in these lists really wasn't needed and had no affect. So that the user doesn't have to provide this value, we have now added a default value for all conditions in this list of "and". CMK-16383 Change-Id: I6efb673590ddaf0c88fc9b5a9edf0f0bd2e9468f Commit: aa2494ff03331ae96d38b97a12dcb836f63b6a99 https://github.com/Checkmk/checkmk/commit/aa2494ff03331ae96d38b97a12dcb836f… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M cmk/gui/openapi/endpoints/rule/fields.py M tests/testlib/rest_api_client.py M tests/unit/cmk/gui/openapi/test_openapi_rules.py Log Message: ----------- Rules: service/host_label group operator now has a default operator key of 'and' The operator field on the LabelGroupCondition was not set a required field, nor did it have a load_default value. This would cause an internal server error if it was not provided. Also, this Condition an item in a list and the first item in this list does not require the operator key. To fix this, I've made added a load_default value. CMK-16383 Change-Id: Ieb37ecb4049fe402b301791f83d5152cbb7a0122 Compare: https://github.com/Checkmk/checkmk/compare/78e4bb4cc65d...aa2494ff0333 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications