[checkmk-commits] [Checkmk/checkmk] 79d1bc: remove pytest fixture, use function instead

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: 79d1bc7fdadb9eca26f67d08e50354ef5c78a22c https://github.com/Checkmk/checkmk/commit/79d1bc7fdadb9eca26f67d08e50354ef5… Author: Benedikt Seidl <benedikt.seidl(a)checkmk.com> Date: 2023-11-20 (Mon, 20 Nov 2023) Changed paths: M tests/unit/cmk/base/plugins/agent_based/test_mssql_backup.py Log Message: ----------- remove pytest fixture, use function instead as soon as you set the environment variable `TZ` to something, the skipped test started to fail. the problem was, that the fixture (parsing the section) was outside the `with on_time` block setting the timezone. So the section was parsed with the timezone of the system which is randomized when executed via `make test-unit`. Change-Id: I740a7ea8cd83c9680fb355a3e5eb8ea71bfc17f1 Commit: 99d7681bc843d2e9735cdb0c5d3ffecd8c3c8697 https://github.com/Checkmk/checkmk/commit/99d7681bc843d2e9735cdb0c5d3ffecd8… Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com> Date: 2023-11-20 (Mon, 20 Nov 2023) Changed paths: A .werks/15976 M agents/windows/plugins/mssql.vbs M cmk/base/plugins/agent_based/mssql_backup.py M tests/unit/cmk/base/plugins/agent_based/test_mssql_backup.py Log Message: ----------- 15976 FIX mssql_backup: Correct timezone difference for last backup date This werk is relevant for users monitoring the age of the last backup time of mssql databases in different timezones. The date/time of the last backup of a mssql database is currently stored in local host time without the information about the host timezone. When this time is used to check the age of the last backup, it is interpreted in the Checkmk server timezone. When using different timezones, this leads to incorrect values for "Age of last database backup" and if the age is negative, in newer Checkmk versions to the warning "Cannot reasonably calculate time since last backup (hosts time running ahead)". The mssql agent plugin will now store the time in UTC and the mssql_backup check will interpret the time accordingly. You will need to update the agent plugin mssql.vbs to receive the corrected times. SUP-14924 SUP-15900 SUP-15976 Co-authored-by: Benedikt Seidl <benedikt.seidl(a)checkmk.com> Change-Id: I6e6e9192632d1f35ff1516b6a3f123b74fb4cd89 Compare: https://github.com/Checkmk/checkmk/compare/a2ea55fa4ecf...99d7681bc843