26 Apr
2022
26 Apr
'22
9:23 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: d2217dcef9c30c65c7df27b9b69cd4449b5d6440
https://github.com/tribe29/checkmk/commit/d2217dcef9c30c65c7df27b9b69cd4449…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2022-04-26 (Tue, 26 Apr 2022)
Changed paths:
M cmk/gui/htmllib/__init__.py
Log Message:
-----------
htmllib: Flatten imports
CMK-10313
Change-Id: Ie2c5d05c9c0874be9a79f00e760df28a23e8a87c
Commit: 5efe0b63672356ad606cc6b04637f0a996f75d8c
https://github.com/tribe29/checkmk/commit/5efe0b63672356ad606cc6b04637f0a99…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2022-04-26 (Tue, 26 Apr 2022)
Changed paths:
M cmk/gui/backup.py
M cmk/gui/bi.py
M cmk/gui/breadcrumb.py
M cmk/gui/context.py
M cmk/gui/crash_handler.py
M cmk/gui/crash_reporting.py
M cmk/gui/dashboard.py
M cmk/gui/display_options.py
M cmk/gui/forms.py
R cmk/gui/globals.py
M cmk/gui/gui_background_job.py
M cmk/gui/hooks.py
M cmk/gui/htmllib/__init__.py
R cmk/gui/htmllib/_tag_rendering.py
A cmk/gui/htmllib/context.py
M cmk/gui/htmllib/foldable_container.py
A cmk/gui/htmllib/generator.py
A cmk/gui/htmllib/html.py
A cmk/gui/htmllib/tag_rendering.py
M cmk/gui/inventory.py
M cmk/gui/key_mgmt.py
M cmk/gui/livestatus_utils/testing.py
M cmk/gui/login.py
M cmk/gui/logwatch.py
M cmk/gui/main.py
M cmk/gui/message.py
M cmk/gui/mobile.py
M cmk/gui/node_visualization.py
M cmk/gui/notifications.py
M cmk/gui/page_menu.py
M cmk/gui/page_state.py
M cmk/gui/pages.py
M cmk/gui/pagetypes.py
M cmk/gui/plugins/dashboard/failed_notifications.py
M cmk/gui/plugins/dashboard/graph.py
M cmk/gui/plugins/dashboard/logo.py
M cmk/gui/plugins/dashboard/overview.py
M cmk/gui/plugins/dashboard/snapin.py
M cmk/gui/plugins/dashboard/static_text.py
M cmk/gui/plugins/dashboard/utils.py
M cmk/gui/plugins/dashboard/view.py
M cmk/gui/plugins/metrics/html_render.py
M cmk/gui/plugins/metrics/utils.py
M cmk/gui/plugins/metrics/valuespecs.py
M cmk/gui/plugins/sidebar/bi.py
M cmk/gui/plugins/sidebar/groups.py
M cmk/gui/plugins/sidebar/master_control.py
M cmk/gui/plugins/sidebar/mkeventd.py
M cmk/gui/plugins/sidebar/nagvis_maps.py
M cmk/gui/plugins/sidebar/performance.py
M cmk/gui/plugins/sidebar/search.py
M cmk/gui/plugins/sidebar/server_time.py
M cmk/gui/plugins/sidebar/site_status.py
M cmk/gui/plugins/sidebar/speedometer.py
M cmk/gui/plugins/sidebar/tactical_overview.py
M cmk/gui/plugins/sidebar/utils.py
M cmk/gui/plugins/sidebar/virtual_host_tree.py
M cmk/gui/plugins/sidebar/wato.py
M cmk/gui/plugins/views/bi.py
M cmk/gui/plugins/views/commands.py
M cmk/gui/plugins/views/crash_reporting.py
M cmk/gui/plugins/views/icons/builtin.py
M cmk/gui/plugins/views/icons/utils.py
M cmk/gui/plugins/views/layouts.py
M cmk/gui/plugins/views/mkeventd.py
M cmk/gui/plugins/views/mobile.py
M cmk/gui/plugins/views/painters.py
M cmk/gui/plugins/views/perfometer.py
M cmk/gui/plugins/views/perfometers/check_mk.py
M cmk/gui/plugins/views/perfometers/utils.py
M cmk/gui/plugins/views/utils.py
M cmk/gui/plugins/views/wato.py
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/plugins/visuals/inventory.py
M cmk/gui/plugins/visuals/node_vis.py
M cmk/gui/plugins/visuals/utils.py
M cmk/gui/plugins/visuals/wato.py
M cmk/gui/plugins/wato/background_job.py
M cmk/gui/plugins/wato/bi_config.py
M cmk/gui/plugins/wato/builtin_attributes.py
M cmk/gui/plugins/wato/utils/__init__.py
M cmk/gui/plugins/wato/utils/base_modes.py
M cmk/gui/plugins/wato/utils/html_elements.py
M cmk/gui/plugins/wato/utils/main_menu.py
M cmk/gui/plugins/wato/utils/simple_modes.py
M cmk/gui/prediction.py
M cmk/gui/robotmk.py
M cmk/gui/sidebar/__init__.py
M cmk/gui/sidebar/main_menu.py
M cmk/gui/table.py
M cmk/gui/user_message.py
M cmk/gui/userdb.py
M cmk/gui/utils/confirm_with_preview.py
M cmk/gui/utils/rendering.py
M cmk/gui/utils/script_helpers.py
M cmk/gui/valuespec.py
M cmk/gui/view_utils.py
M cmk/gui/views/__init__.py
M cmk/gui/views/availability.py
M cmk/gui/views/inventory.py
M cmk/gui/visuals.py
M cmk/gui/wato/__init__.py
M cmk/gui/wato/mkeventd.py
M cmk/gui/wato/page_handler.py
M cmk/gui/wato/pages/activate_changes.py
M cmk/gui/wato/pages/analyze_configuration.py
M cmk/gui/wato/pages/audit_log.py
M cmk/gui/wato/pages/bulk_discovery.py
M cmk/gui/wato/pages/bulk_edit.py
M cmk/gui/wato/pages/bulk_import.py
M cmk/gui/wato/pages/check_catalog.py
M cmk/gui/wato/pages/custom_attributes.py
M cmk/gui/wato/pages/diagnostics.py
M cmk/gui/wato/pages/download_agents.py
M cmk/gui/wato/pages/fetch_agent_output.py
M cmk/gui/wato/pages/folders.py
M cmk/gui/wato/pages/global_settings.py
M cmk/gui/wato/pages/groups.py
M cmk/gui/wato/pages/host_diagnose.py
M cmk/gui/wato/pages/host_rename.py
M cmk/gui/wato/pages/hosts.py
M cmk/gui/wato/pages/icons.py
M cmk/gui/wato/pages/ldap.py
M cmk/gui/wato/pages/not_implemented.py
M cmk/gui/wato/pages/notifications.py
M cmk/gui/wato/pages/object_parameters.py
M cmk/gui/wato/pages/parentscan.py
M cmk/gui/wato/pages/password_store.py
M cmk/gui/wato/pages/pattern_editor.py
M cmk/gui/wato/pages/predefined_conditions.py
M cmk/gui/wato/pages/random_hosts.py
M cmk/gui/wato/pages/read_only.py
M cmk/gui/wato/pages/roles.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/wato/pages/search.py
M cmk/gui/wato/pages/services.py
M cmk/gui/wato/pages/sites.py
M cmk/gui/wato/pages/tags.py
M cmk/gui/wato/pages/timeperiods.py
M cmk/gui/wato/pages/user_profile/abstract_page.py
M cmk/gui/wato/pages/user_profile/async_replication.py
M cmk/gui/wato/pages/user_profile/change_password.py
M cmk/gui/wato/pages/user_profile/edit_profile.py
M cmk/gui/wato/pages/user_profile/replicate.py
M cmk/gui/wato/pages/user_profile/two_factor.py
M cmk/gui/wato/pages/users.py
M cmk/gui/watolib/__init__.py
M cmk/gui/watolib/activate_changes.py
M cmk/gui/watolib/audit_log.py
M cmk/gui/watolib/groups.py
M cmk/gui/watolib/host_attributes.py
M cmk/gui/watolib/hosts_and_folders.py
M cmk/gui/watolib/rulesets.py
M cmk/gui/watolib/rulespecs.py
M cmk/gui/werks.py
M cmk/gui/wsgi/applications/checkmk.py
M omd/packages/appliance/webconf_snapin.py
M tests/unit/cmk/gui/htmllib/test_html_cls.py
M tests/unit/cmk/gui/htmllib/test_tag_rendering.py
M tests/unit/cmk/gui/plugins/views/perfometers/test_perfometer_fileinfo.py
M tests/unit/cmk/gui/test_dashboard.py
M tests/unit/cmk/gui/test_forms.py
M tests/unit/cmk/gui/test_http.py
M tests/unit/cmk/gui/test_index.py
M tests/unit/cmk/gui/test_sidebar.py
M tests/unit/cmk/gui/test_table.py
M tests/unit/cmk/gui/test_valuespec.py
M tests/unit/cmk/gui/views/test_views.py
M tests/unit/cmk/gui/wato/pages/test_rulesets.py
M tests/unit/cmk/gui/watolib/test_changes.py
Log Message:
-----------
Reorganize htmllib
- rename class html -> HTMLGenerator: The name "html" was used to
name an *instance* of the "html" class. This is confusing.
- split `htmllib.__init__` into `htmllib.generator` and `htmllib.html`.
Note that inheritance between the two classes is not strictly
necessary: the only abstract method to ABC is `_write()`. A
strategy or a free function would be much simpler.
- avoid transient imports in callers: They tend to be involved
in cyclic dependencies. They are confusing as well.
- scope globals under htmllib, there is but a single instance here now.
CMK-10313
Change-Id: I54f3312b1aad0ab1ef3432747ee0d06b3e51d588
Commit: 28c63ae7f55bed72c5eb00f96537dca3e25fb8f4
https://github.com/tribe29/checkmk/commit/28c63ae7f55bed72c5eb00f96537dca3e…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2022-04-26 (Tue, 26 Apr 2022)
Changed paths:
M cmk/gui/htmllib/generator.py
M cmk/gui/htmllib/html.py
Log Message:
-----------
htmllib: Add staticmethod decorator where appropriate
CMK-10313
Change-Id: I954f6e33ea8eb46989d885ec9ad032458e5a6f26
Compare: https://github.com/tribe29/checkmk/compare/be3a58ff8d9e...28c63ae7f55b