[checkmk-commits] Replaced needless eval() calls

Module: check_mk Branch: master Commit: 1d03ab4d68baf889258f28683011fdeb6d628525 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1d03ab4d68baf8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Nov 9 17:14:46 2016 +0100 Replaced needless eval() calls --- cmk_base/prediction.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmk_base/prediction.py b/cmk_base/prediction.py index 9eb05c0..be6bc7a 100644 --- a/cmk_base/prediction.py +++ b/cmk_base/prediction.py @@ -29,6 +29,7 @@ import os import time import math +import ast import livestatus @@ -238,7 +239,7 @@ def get_levels(hostname, service_description, dsname, params, cf, levels_factor= # - the prediction from the last time is outdated # - the prediction from the last time has done with other parameters try: - last_info = eval(file(info_file).read()) + last_info = ast.literal_eval(file(info_file).read()) for k, v in params.items(): if last_info.get(k) != v: logger.verbose("Prediction parameters have changed") @@ -253,8 +254,7 @@ def get_levels(hostname, service_description, dsname, params, cf, levels_factor= last_info = None if last_info: - # TODO: faster file format. Binary encoded? - prediction = eval(file(pred_file).read()) + prediction = ast.literal_eval(file(pred_file).read()) else: # Remove all prediction files that result from other @@ -263,7 +263,7 @@ def get_levels(hostname, service_description, dsname, params, cf, levels_factor= for f in os.listdir(dir): if f.endswith(".info"): try: - info = eval(file(dir + "/" + f).read()) + info = ast.literal_eval(file(dir + "/" + f).read()) if info["period"] != params["period"]: logger.verbose("Removing obsolete prediction %s", f[:-5]) os.remove(dir + "/" + f)