19 Nov
2019
19 Nov
'19
4:10 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 48f9ce12a441129426eac1592de5e74adbef83b7
https://github.com/tribe29/checkmk/commit/48f9ce12a441129426eac1592de5e74ad…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
M checks/check_http
M tests/unit/checks/test_check_http.py
Log Message:
-----------
check_http: don't use the -H option when a proxy is used
In the proxy case the hostname is not set via the -H option,
but given as the second positional argument. If -H is given
anyway the second positional argument will override it. To
make the use of the second positional argument more explicit
we now omit the -H option entirely in this case.
Add a test case along the way.
CMK-3184
Change-Id: Ib241d2beb4fe979cd8b054fab2d927f35ac03332
Commit: 809bd833ad1bcd4e3f564fd99f482be21c0b42e6
https://github.com/tribe29/checkmk/commit/809bd833ad1bcd4e3f564fd99f482be21…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
M checks/check_http
M tests/unit/checks/test_check_http.py
Log Message:
-----------
check_http: always use the second positional argument to set the hostname
The hostname can be set either with the -H option or via the
second positional argument. We now use the second argument
exclusively to set the hostname.
CMK-3184
Change-Id: Ia8885519b2d460740c7fcfd3d26c285cb171eeb3
Commit: 305a7629b5fdf8ec0bdb0770e48f57de958b5608
https://github.com/tribe29/checkmk/commit/305a7629b5fdf8ec0bdb0770e48f57de9…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
M checks/check_http
Log Message:
-----------
check_http: simplify logic to determine host name and server address
CMK-3184
Change-Id: I8df04470cbf9a01fcd8e6a33e8e75f7625128ce2
Commit: d762f68ee80c287d39ee546f47e627d70fccb722
https://github.com/tribe29/checkmk/commit/d762f68ee80c287d39ee546f47e627d70…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
M checks/check_http
Log Message:
-----------
check_http: don't alias host.address and host.virtual
CMK-3184
Change-Id: I7c9f70f5f238e4ed32d9792c02bba0c0bb782cb2
Commit: 57ca914154a7751698a12b4fa358a7d834507b7e
https://github.com/tribe29/checkmk/commit/57ca914154a7751698a12b4fa358a7d83…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
A .werks/10451
M checks/check_http
M cmk/gui/plugins/wato/active_checks.py
M tests/unit/checks/test_check_http.py
Log Message:
-----------
10451 FIX check_http: don't set virtual host if not necessary
Since version 1.6 the active check check_http automatically
set the HTTP Host header and used HTTP/1.1 instead of HTTP/1.0
even if no virtual host was supplied. This may lead to
timeouts of the check_http plugin on servers which are not
fully compliant with HTTP/1.1.
This werk changes this behaviour so that the Host header is
only set if a virtual host is given.
Please note that if you rely on HTTP/1.1 or want to use it you
have to supply a virtual host.
Please also note that the virtual host will not be set
automatically to the host name anymore. If you relied on this
behaviour you now have to provide the virtual host in the
affected rules.
CMK-3184
Change-Id: I82c1936acc4d4cba8265b21f6a5b587e9823c9f4
Compare: https://github.com/tribe29/checkmk/compare/baa2c117ed02...57ca914154a7