10 May
2023
10 May
'23
10:03 a.m.
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 0cf064861fbe19bc794ae2c6159e95173b1bc802
https://github.com/Checkmk/checkmk/commit/0cf064861fbe19bc794ae2c6159e95173…
Author: Alex Zurhake <alex.zurhake(a)tribe29.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M omd/Makefile
M omd/WORKSPACE
A omd/packages/lcab/BUILD
A omd/packages/lcab/BUILD.lcab.bazel
A omd/packages/lcab/lcab.make
A omd/packages/lcab/lcab_http.bzl
R omd/packages/msitools/lcab-1.0b12.tar.gz
M omd/packages/msitools/msitools.make
M omd/packages/packages.make
Log Message:
-----------
Bazelize lcab
Extract lcab from msitools into it's own package
Change-Id: I90800f640933dd7c7e50603641c02dab8de66d3a
Commit: b4e540536803879a98a60030dfc40254908a2561
https://github.com/Checkmk/checkmk/commit/b4e540536803879a98a60030dfc402549…
Author: Alex Zurhake <alex.zurhake(a)tribe29.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M omd/WORKSPACE
A omd/packages/msitools/BUILD
A omd/packages/msitools/BUILD.msitools.bazel
R omd/packages/msitools/msitools-0.94.tar.gz
M omd/packages/msitools/msitools.make
A omd/packages/msitools/msitools_http.bzl
A omd/packages/msitools/patches/BUILD
Log Message:
-----------
Bazelize msitools
Change-Id: I71e3bfac9b7b34e1aaab41e18dc3f97e9aafd0ec
Commit: d7789debfbc5d8528b2582884e7acd821af4881c
https://github.com/Checkmk/checkmk/commit/d7789debfbc5d8528b2582884e7acd821…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M checks/arbor_peakflow_sp
M checks/elasticsearch_cluster_health
M checks/enterasys_lsnat
M checks/fireeye_active_vms
M checks/fireeye_mail
M checks/fireeye_quarantine
M checks/graylog_cluster_stats
M checks/graylog_cluster_traffic
M checks/graylog_messages
M checks/jenkins_queue
M checks/splunk_alerts
M checks/splunk_health
M checks/splunk_jobs
Log Message:
-----------
make vulture happy II: unused `no_item`
Change-Id: Icde1d77549b2ea5afb3fe72f27a80dc779487699
Commit: 45c2bb3cbd26d6f9620c5073da4b06ef29979bfc
https://github.com/Checkmk/checkmk/commit/45c2bb3cbd26d6f9620c5073da4b06ef2…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M checks/arbor_peakflow_tms
M checks/casa_fan
M checks/casa_power
M checks/cisco_power
M checks/citrix_hostsystem
M checks/cmctc_psm_m
M checks/db2_bp_hitratios
M checks/db2_version
Log Message:
-----------
make vulture happy III: unused `no_params`
Change-Id: I9d805eb6bf1905c597ce5cc81e17bfc1ea461908
Commit: 0f815960d5fb860bd8e70f6ea9a76af8bbbd0b5c
https://github.com/Checkmk/checkmk/commit/0f815960d5fb860bd8e70f6ea9a76af8b…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M checks/blade_bx_powerfan
M checks/dell_chassis_status
M checks/dell_powerconnect_fans
M checks/emc_isilon_ifs
M checks/hpux_tunables
M checks/jolokia_jvm_memory
M checks/jolokia_metrics
M checks/lparstat_aix
M checks/mem
M checks/netapp_api_cpu
M checks/prometheus_custom
M checks/raritan_pdu_plugs
M checks/supermicro
M checks/systemtime
M checks/ucd_cpu_util
Log Message:
-----------
make vulture happy IV: drop unused constants
Change-Id: I962f9f499c0620e58047e5fb3f0d409fe25a1e7e
Commit: f1fe93381f0a028bc3f7c6a0895e1662b94fdef7
https://github.com/Checkmk/checkmk/commit/f1fe93381f0a028bc3f7c6a0895e1662b…
Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M cmk/gui/wato/pages/folders.py
M cmk/gui/wato/pages/hosts.py
M cmk/gui/watolib/hosts_and_folders.py
M tests/unit/cmk/gui/utils/test_theme.py
A web/htdocs/themes/facelift/images/emblem_remove.png
A web/htdocs/themes/facelift/images/icon_tls.svg
M web/htdocs/themes/facelift/scss/_pages.scss
A web/htdocs/themes/modern-dark/images/icon_search.svg
Log Message:
-----------
Setup hosts: Add some new icons
... for "Remove TLS registration" and generally for searches in the dark
theme. Adjust unit test for dark theme images to check only for file
name stems, disregarding file extension.
CMK-13036
Change-Id: I16ea3bc78fecbb9c8af7c29c7b7ba6e63c63a6d8
Commit: 09e10e89eb8c93352c0e02878c9c941a5a9b05d2
https://github.com/Checkmk/checkmk/commit/09e10e89eb8c93352c0e02878c9c941a5…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M cmk/base/agent_based/inventory/__init__.py
R cmk/base/agent_based/inventory/commandline.py
M cmk/base/modes/check_mk.py
Log Message:
-----------
Inline `commandline_inventory()`
Function has a single caller.
CMK-12298
Change-Id: I021abf4a07c091f59c2362ea86b075dae933d4df
Commit: 4226e8ebcfe4eda52a5a3672afdef3fa21566197
https://github.com/Checkmk/checkmk/commit/4226e8ebcfe4eda52a5a3672afdef3fa2…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M cmk/base/agent_based/inventory/__init__.py
R cmk/base/agent_based/inventory/_autoinventory.py
M cmk/base/modes/check_mk.py
Log Message:
-----------
Inline `inventorize_marked_hosts()
Function has a single caller
Change-Id: Ibf962aeb32ce41cd313dfc2919d822b5c47e3298
Commit: 05a288b4c6199517d5cb242917a09fe5e4d87e59
https://github.com/Checkmk/checkmk/commit/05a288b4c6199517d5cb242917a09fe5e…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M cmk/base/agent_based/inventory/__init__.py
R cmk/base/agent_based/inventory/_active.py
M cmk/base/modes/check_mk.py
M tests/unit/cmk/base/agent_based/test_base_inventory.py
Log Message:
-----------
Move `execute_active_check_inventory()` to caller
This patch and the previous "inline" patches improve the inventory code
in that,
* It clarifies the layering between the library part of the inventory
checker containing the business logic, testable, independant from
implementation details such as the check api and the configuration,
and its users.
* There only remains 3, non-redundant, not-copy-and-pasted entry points
into the library part of the checker under
`cmk.base.agent_based.inventory`.
* The copy pasted parts are now in the same file (improved visibility
if we want to fix that later + cohesion). Further note that a bit of
copy-and-paste in *user* code isn't necessarily a problem.
CMK-12298
Change-Id: I27485becbd5117f3bf8a546560979633351b0b75
Commit: 2a8e7b5121589933cc00e53e570c8c01a9ec6c46
https://github.com/Checkmk/checkmk/commit/2a8e7b5121589933cc00e53e570c8c01a…
Author: Mathias Laurin <mathias.laurin(a)checkmk.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
M cmk/base/agent_based/checking/_checking.py
R cmk/base/agent_based/inventory/__init__.py
R cmk/base/agent_based/inventory/_inventory.py
M cmk/base/modes/check_mk.py
M cmk/checkers/inventory.py
M cmk/checkers/sectionparser.py
M tests/unit/cmk/base/agent_based/test_base_inventory.py
Log Message:
-----------
Move inventory to check engine
Now that it is entirely free from base deps, let's move it to a
module where it may be more expected: The check engine.
CMK-12298
Change-Id: I51b5751a748aceddd17c210d8b4cc96577c560b8
Commit: 969e62085e5c66b5c158c06f0284286fa78944b4
https://github.com/Checkmk/checkmk/commit/969e62085e5c66b5c158c06f0284286fa…
Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
A .werks/15264
M cmk/base/plugins/agent_based/logwatch.py
M cmk/base/plugins/agent_based/logwatch_ec.py
M cmk/base/plugins/agent_based/utils/logwatch.py
M cmk/gui/plugins/wato/check_parameters/logwatch_ec.py
M tests/unit/cmk/base/plugins/agent_based/test_logwatch.py
M tests/unit/cmk/base/plugins/agent_based/test_logwatch_ec.py
Log Message:
-----------
15264 FIX Check plugins logwatch, logwatch_ec: Notify about unreadable log file
In the Logwatch and Logwatch Event Console Forwarding Check unreadable log files (e.g. due
to insufficient permssions) were previously treated the same as missing log files.
With this werk, the checks will check specifically for log files that could not be read
and will become {CRIT} if any are present.
To configure the state for the Event Console Forwarding service when unreadable files are
detected, use the option "State if a logfile cannot be read" in the rule
<i>Logwatch Event Console Forwarding</i>.
SUP-12770
Change-Id: I4d0186b76235396b864ceadcdecf032e45fd7e3d
Commit: 74dd2f8c70aedb2032fe510b8aea40b9688d6704
https://github.com/Checkmk/checkmk/commit/74dd2f8c70aedb2032fe510b8aea40b96…
Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com>
Date: 2023-05-10 (Wed, 10 May 2023)
Changed paths:
A .werks/15266
M cmk/base/plugins/agent_based/logwatch_ec.py
M tests/unit/cmk/base/plugins/agent_based/test_logwatch_ec.py
Log Message:
-----------
15266 FIX Check plugin logwatch_ec: Improve detection of missing log files
Previously the Logwatch Event Console Forwarding service would not report log files as
missing that are marked as such in the agent output:
F+:
<<<logwatch>>>
[[[logfile:missing]]]
F-:
This affected logfiles that were explicitly configured to be monitored, as opposed to
configurations that capture multiple logfiles at once.
With this werk this has been fixed.
SUP-12770
Change-Id: Idfc972fce51c0bdeaaf7f73d56d38d15e59cdb34
Compare: https://github.com/Checkmk/checkmk/compare/857538cf130c...74dd2f8c70ae