[checkmk-commits] [tribe29/checkmk] f6ee8b: mssql_vbs: object to encapsulate database interaction

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f6ee8ba2f340c48b186ca6a1b3de0826408ae4cc https://github.com/tribe29/checkmk/commit/f6ee8ba2f340c48b186ca6a1b3de08264… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2022-10-05 (Wed, 05 Oct 2022) Changed paths: M agents/windows/plugins/mssql.vbs Log Message: ----------- mssql_vbs: object to encapsulate database interaction Background: * will replace connections with the database scattered all over the script using the "CONN" object * will be implemented fully in a later commit, split like this for easier review Added benefits: * consistent way of communicating with database Tests: * CI does not support unit tests vor .vbs scripts * manual run to ensure the script still works SUP-11620 Change-Id: Ie944052c6a05d233b74f961ded1e0d9b20b2bd08 Commit: 988e26f227c320378f419258a1387c358719141d https://github.com/tribe29/checkmk/commit/988e26f227c320378f419258a1387c358… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2022-10-05 (Wed, 05 Oct 2022) Changed paths: M agents/windows/plugins/mssql.vbs Log Message: ----------- mssql_vbs: connection logging and more complicated response type Background: * will replace connections with the database scattered all over the script using the "CONN" object * will be implemented fully in a later commit, split like this for easier review Added benefits: * access logging if connection is anything other than "open" * helper functions to encapsulate any formatting/parsing Tests: * CI does not support unit tests vor .vbs scripts * manual run to ensure the script still works SUP-11620 Change-Id: I3de92e72eb9c3c204c9a0538ad9ae45e41ceaa84 Commit: e15c6fc9a11f712762dda24203269e529cd2b452 https://github.com/tribe29/checkmk/commit/e15c6fc9a11f712762dda24203269e529… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2022-10-05 (Wed, 05 Oct 2022) Changed paths: M agents/windows/plugins/mssql.vbs Log Message: ----------- mssql_vbs: method to perform system wide queries Background: * will replace connections with the database scattered all over the script using the "CONN" object * will be implemented fully in a later commit, split like this for easier review Added benefits: * consistent way of performing SQL queries against the server * consistent way of evaluating server response and making sure it is done (see SUP) * consistent response types with queryResponse/errorResponse * helper functions to encapsulate any formatting/parsing * it is ensured that objects are terminated properly after every query Tests: * CI does not support unit tests vor .vbs scripts * manual run to ensure the script still works SUP-11620 Change-Id: Idde57b22108435ed37c74724328cf347857fe0cf Commit: 71949a02548fd6ae58e7af1681a97b836cc81b2a https://github.com/tribe29/checkmk/commit/71949a02548fd6ae58e7af1681a97b836… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2022-10-05 (Wed, 05 Oct 2022) Changed paths: M agents/windows/plugins/mssql.vbs Log Message: ----------- mssql_vbs: method to perform database specific queries Background: * will replace connections with the database scattered all over the script using the "CONN" object * will be implemented fully in a later commit, split like this for easier review Added benefits: * consistent way of performing SQL queries against the server * consistent way of evaluating server response and making sure it is done (see SUP) * consistent response types with queryResponse/errorResponse * helper functions to encapsulate any formatting/parsing * it is ensured that objects are terminated properly after every query Tests: * CI does not support unit tests vor .vbs scripts * manual run to ensure the script still works SUP-11620 Change-Id: I698d05b2efb6c7c04a88d56a46f5318d848881a4 Commit: 072c970a1964e4321eddf79aa9ed7a34075c54c5 https://github.com/tribe29/checkmk/commit/072c970a1964e4321eddf79aa9ed7a340… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2022-10-05 (Wed, 05 Oct 2022) Changed paths: M agents/windows/plugins/mssql.vbs Log Message: ----------- mssql_vbs: reformat queries and move to variable for easier reading Tests: * CI does not support unit tests vor .vbs scripts * manual run to ensure the script still works SUP-11620 Change-Id: Ic73e07e52791df769ad4440113759df88184477d Commit: 8028dc8b3f4c952e56e673761bd47dbc7197509b https://github.com/tribe29/checkmk/commit/8028dc8b3f4c952e56e673761bd47dbc7… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2022-10-05 (Wed, 05 Oct 2022) Changed paths: A .werks/14768 M agents/windows/plugins/mssql.vbs Log Message: ----------- 14768 FIX mssql.vbs: some database specific sections contain data from a different database Use interface for database connection and interaction. Tests: * CI does not support unit tests vor .vbs scripts * regression tests against a MSSQL test instance * customer test SUP-11620 Change-Id: I0beaf29eec2bba0c38db10b00eaca9b634a20157 Compare: https://github.com/tribe29/checkmk/compare/63a73805e850...8028dc8b3f4c