[checkmk-commits] [tribe29/checkmk] d7d7a3: agent_based: Add tests for the decorators

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d7d7a3582221911a5aab37f157285e367f2fbe01 https://github.com/tribe29/checkmk/commit/d7d7a3582221911a5aab37f157285e367… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-07-19 (Tue, 19 Jul 2022) Changed paths: A tests/unit/cmk/base/agent_based/test_decorator.py M tests/unit/conftest.py Log Message: ----------- agent_based: Add tests for the decorators The decorators are used in the global scope and need to access the config. This requires that the config is global as well. However, we now want to have a more local and instantiable config. We therefore need to change the decorators into something else. Here, we simply add tests in order to insure that the functionality is not lost in a later reengineering. CMK-10515 Change-Id: I417e3b418f42350e43bc9d6c986f69f15315d466 Commit: 2e7d96e1fb36d329c35f7461fc9c5bb0da4184cc https://github.com/tribe29/checkmk/commit/2e7d96e1fb36d329c35f7461fc9c5bb0d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-07-19 (Tue, 19 Jul 2022) Changed paths: M cmk/base/agent_based/checking/__init__.py R cmk/base/agent_based/decorator.py M cmk/base/agent_based/discovery/__init__.py A cmk/base/agent_based/error_handling.py M cmk/base/agent_based/inventory/__init__.py R tests/unit/cmk/base/agent_based/test_decorator.py A tests/unit/cmk/base/agent_based/test_error_handling.py Log Message: ----------- Rename decorator module -> error_handling The fact that the error handling is implemented as a decorator is an irrelevant implementation detail. Interesting is *what* the purpose of this decorator *is*. CMK-10515 Change-Id: If940b903f0817a348f539bdd58c1d2435b265040 Commit: a96c596b04879ede3772e2cc1ae23f5c255a3a7d https://github.com/tribe29/checkmk/commit/a96c596b04879ede3772e2cc1ae23f5c2… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-07-19 (Tue, 19 Jul 2022) Changed paths: M cmk/base/agent_based/error_handling.py Log Message: ----------- agent_based: Structure error-handling decorator The decorator actually does three things so let us split the functionality into three functions. This is proper "structured programming" such as advertised by Dijkstra in his "Notes on structured programming" (1972). This should let us implement the logic without a decorator more easily in another patch. CMK-10515 Change-Id: I92ea3270ed5953b9a1158fa60835678b0bfa890c Compare: https://github.com/tribe29/checkmk/compare/3b5fe2880744...a96c596b0487