9 Aug
2019
9 Aug
'19
8 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: c0d814e2c5f5e39b4c6fc098669d2f72d3975c62
https://github.com/tribe29/checkmk/commit/c0d814e2c5f5e39b4c6fc098669d2f72d…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2019-08-09 (Fri, 09 Aug 2019)
Changed paths:
M bin/check_mk
M cmk/ec/main.py
M cmk/gui/cron.py
M cmk/gui/dashboard.py
M cmk/gui/log.py
M cmk/gui/metrics.py
M cmk/gui/multitar.py
M cmk/gui/plugins/views/perfometer.py
M cmk/gui/plugins/views/utils.py
M cmk/gui/plugins/webapi/utils.py
M cmk/gui/sidebar.py
M cmk/gui/userdb.py
M cmk/gui/wato/__init__.py
M cmk/gui/wato/pages/analyze_configuration.py
M cmk/gui/wato/pages/global_settings.py
M cmk/gui/wato/pages/ldap.py
M cmk/gui/wato/pages/sites.py
M cmk/gui/watolib/__init__.py
M cmk/gui/watolib/activate_changes.py
M cmk/gui/watolib/analyze_configuration.py
M cmk/gui/watolib/automations.py
M cmk/gui/watolib/git.py
M cmk/gui/watolib/rulesets.py
M cmk/update_config.py
M cmk/utils/log.py
M cmk/utils/prediction.py
M cmk/utils/store.py
M cmk_base/compress_history.py
M cmk_base/console.py
M cmk_base/core_nagios.py
M cmk_base/localize.py
M cmk_base/packaging.py
M cmk_base/prediction.py
M tests/unit/cmk/ec/test_event_creator.py
M tests/unit/cmk/ec/test_perfcounters.py
M tests/unit/cmk/ec/test_rule_matching.py
M tests/unit/cmk/utils/test_log.py
M web/app/index.wsgi
Log Message:
-----------
Nuked cmk.utils.log.get_logger()
It was not helpful, even a bit harmful:
* It was not an abstraction at all: The names of quite a few loggers are
hardwired into our configuration, so explicitly requesting a specific
logger is more honest than using a pseudo-abstraction.
* It was obviously confusing to many people: Various places produced funny
and probably unintended logger names like "cmk.cmk.utils.prediction" or
"cmk.cmk_base.packaging".
* It confuses pylint, effectively disabling the logging-not-lazy check.
Most of this commit is actually fixing this and improving laziness.
* It doesn't exceed the "Fairbairn Threshold", i.e. the point at which the
effort of looking up or keeping track of the definition is outweighed by
the effort of rederiving it or inlining it.
(https://wiki.haskell.org/Fairbairn_threshold):
Change-Id: I206890c486dded0b6060740812a1b247318481cb