[checkmk-commits] [tribe29/checkmk] d4e862: sources: Passing ConfigCache breaks layering

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: d4e86250a5f2d996f0c999a27b8be94ff3c23214 https://github.com/tribe29/checkmk/commit/d4e86250a5f2d996f0c999a27b8be94ff… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-07 (Tue, 07 Mar 2023) Changed paths: M cmk/base/_sources.py M cmk/base/sources.py Log Message: ----------- sources: Passing ConfigCache breaks layering The base class can't have dependencies on cmk.base. Change-Id: I987a0f810b60ac35dc2697dc7f0bc3a78d9dc741 Commit: e27db27f53b6f3b05f7fc798c0abe019726bd851 https://github.com/tribe29/checkmk/commit/e27db27f53b6f3b05f7fc798c0abe0197… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-07 (Tue, 07 Mar 2023) Changed paths: M cmk/base/_sources.py M cmk/base/sources.py M cmk/checkers/__init__.py M cmk/checkers/_api.py Log Message: ----------- sources: Move base Source class to checkers Change-Id: I623b011d231fffc887fb0b3b900cb7aa0d23ea61 Commit: 0b1ade39ff998d82c73034b6dd5b69a47626de88 https://github.com/tribe29/checkmk/commit/0b1ade39ff998d82c73034b6dd5b69a47… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-07 (Tue, 07 Mar 2023) Changed paths: M cmk/base/agent_based/confcheckers.py M cmk/base/automations/check_mk.py M cmk/base/dump_host.py M cmk/base/modes/check_mk.py M cmk/base/sources.py M tests/unit/cmk/base/sources/test_data_sources.py Log Message: ----------- sources: Let make_sources return a Source object Change-Id: I9db576160031475411e1767343e3488c5ee87ef4 Commit: 99acb42f137d9de30955007dd1edcd4d3c87f004 https://github.com/tribe29/checkmk/commit/99acb42f137d9de30955007dd1edcd4d3… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-07 (Tue, 07 Mar 2023) Changed paths: M cmk/base/config.py Log Message: ----------- Fixup config cache use of setdefault The `default` branch of `dict.setdefault()` is executed *before* the call to `__getitem__`. However, the goal of the cache is to short-circuit this possibly expensive computation. We therefore need to check whether a value has been cached in a previous call before calling setdefault. Change-Id: Iea450608c347688bc69cd15f337f1ddc1fadc6c9 Compare: https://github.com/tribe29/checkmk/compare/45c725c15e6e...99acb42f137d