[checkmk-commits] [Checkmk/checkmk] 8d26d6: gui-e2e tests: initialize `LoginPage` with `creden...

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 8d26d6ebc14e512ab05b6e8728fbe7c22b9a8663 https://github.com/Checkmk/checkmk/commit/8d26d6ebc14e512ab05b6e8728fbe7c22… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M tests/gui_e2e/conftest.py M tests/gui_e2e/test_asvs.py M tests/gui_e2e/test_menu_user.py M tests/testlib/playwright/helpers.py M tests/testlib/playwright/pom/dashboard.py M tests/testlib/site.py Log Message: ----------- gui-e2e tests: initialize `LoginPage` with `credentials`. + Consolidated "username:password" -> CmkCredentials. + always pass `credentials` to `LoginPage::login`. + `Dont Repeat Yourself` principal for handling credentials * added `ADMIN_USER`, `AUTOMATION_USER` within `testlib.site` * adapt `testlib.site` accordingly + adapted corresponding test-cases and code. Change-Id: I9df9d2771833e8e36d648cd6a6b9d7e9be40ce15 Commit: 48fa06d74ae7d38b59add6bf9cf7927864f213b8 https://github.com/Checkmk/checkmk/commit/48fa06d74ae7d38b59add6bf9cf792786… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M tests/gui_e2e/conftest.py Log Message: ----------- gui-e2e tests: prefix `gui_e2e.conftest::log_in` with `_`. Function is meant to be used within `gui_e2e.conftest`. Change-Id: I244bab3dc523111c7d1a4c233157548033c8f6ed Commit: 38d89e940e50264a14277cd5a2dc00dcf6d021da https://github.com/Checkmk/checkmk/commit/38d89e940e50264a14277cd5a2dc00dcf… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M tests/gui_e2e/test_asvs.py M tests/testlib/playwright/pom/dashboard.py Log Message: ----------- gui-e2e tests: update `LoginPage` interface. + `site_url` must be provided to initialize `LoginPage`. + promotes consistency in usage of `LoginPage` + adapted corresponding test-case(s). Change-Id: Ic3b92990e76c1825cc70ea89280fdcddd798d98e Commit: 2ce09c15f5e9453c5ce1a390fae13459bf62a68e https://github.com/Checkmk/checkmk/commit/2ce09c15f5e9453c5ce1a390fae13459b… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M tests/gui_e2e/conftest.py Log Message: ----------- gui-e2e tests: update arguments used in `gui_e2e.conftest::_log_in`. `test_site` can be used within `_log_in` function to decide which website needs to be used. Change-Id: I592e497ae71aec593f510a8049f13a42bdabf43b Commit: c8cb669a4c8f13d52aa114176268892a79704fd9 https://github.com/Checkmk/checkmk/commit/c8cb669a4c8f13d52aa114176268892a7… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M tests/gui_e2e/conftest.py M tests/gui_e2e/test_asvs.py M tests/testlib/playwright/pom/dashboard.py M tests/testlib/playwright/pom/werks.py Log Message: ----------- gui_e2e tests: populate `LoginPage::navigate`. + `LoginPage::navigate` validates + User and password the GUI elements. + `LoginPage` attributes + removed `site_id` as it is not used + added `_logged_in` to denote a user has logged-into the GUI. + adapt `gui_e2e.conftest::_log_in` + adapt corresponding test-cases and code. Change-Id: I55d845670deef31ec721b82eb8128b39f0ec3d17 Commit: 99ef7b6e536d47729619237a891947d497dd45b6 https://github.com/Checkmk/checkmk/commit/99ef7b6e536d47729619237a891947d49… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M tests/gui_e2e/conftest.py M tests/gui_e2e/test_asvs.py M tests/testlib/playwright/pom/dashboard.py Log Message: ----------- gui-e2e tests: extend `login` and `logout` within `LoginPage`. + validate change in page URL. Change-Id: I9b071069ec2538a152f06ae84ae0ba17909afc39 Commit: 32a3e75fa2a747b59a999994016818d89be84123 https://github.com/Checkmk/checkmk/commit/32a3e75fa2a747b59a999994016818d89… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M tests/gui_e2e/test_login.py M tests/testlib/playwright/pom/dashboard.py Log Message: ----------- gui-e2e tests: validate page redirection after login. Login page could consist of page URLs, which are redirected to after a successful login. Added code to parse the URL of the redirected page. Then validate the page has navigated to the redirected URL. CMK-16737 Change-Id: Ib28fa4c16c9df8d8a798ae5fb2a37e2cc68f2be7 Commit: 507615091972c46b647290808205bca82a887855 https://github.com/Checkmk/checkmk/commit/507615091972c46b647290808205bca82… Author: Sofia Colakovic <sofia.colakovic(a)checkmk.com> Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M cmk/update_config/plugins/lib/autochecks.py Log Message: ----------- apc_powerswitch: upgrade old discovery parameters Old apc_powerswitch discovery parameters are upgraded to the new format during `omd update`. CMK-17096 Change-Id: Idb26f7955baf93e53969c6ea4a768763f3fc79b5 Compare: https://github.com/Checkmk/checkmk/compare/fde944c81fb5...507615091972 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications