[checkmk-commits] #2832 netscaler_vserver: improved check output for unknown protocols

Module: check_mk Branch: master Commit: a28662a74b3e58175ebcee978f430939078af8b0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a28662a74b3e58… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Jan 26 11:17:40 2016 +0100 #2832 netscaler_vserver: improved check output for unknown protocols This check now also shows the internal code number for the service type in the check output, e.g. serviceUnknown(50), in case it is not in the well known services list. --- .werks/2832 | 12 ++++++++++++ ChangeLog | 1 + checks/netscaler_vserver | 4 ++-- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/.werks/2832 b/.werks/2832 new file mode 100644 index 0000000..589249b --- /dev/null +++ b/.werks/2832 @@ -0,0 +1,12 @@ +Title: netscaler_vserver: improved check output for unknown protocols +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1453803324 +Class: feature + +This check now also shows the internal code number for the service +type in the check output, e.g. serviceUnknown(50), in case it is not +in the well known services list. + diff --git a/ChangeLog b/ChangeLog index 6565f0b..44ea1aa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -97,6 +97,7 @@ * 2937 mrpe: check now supports service descriptions using percent-encoded characters... NOTE: Please refer to the migration notes! * 2938 websphere_mq_channels: check outcome based on channel state is now configurable... + * 2832 netscaler_vserver: improved check output for unknown protocols... * 2660 FIX: fixed windows agent using the wrong working directory... * 2664 FIX: ps: Speedup in situation with many matching processes... * 2661 FIX: windows agent: fixed incomplete process list... diff --git a/checks/netscaler_vserver b/checks/netscaler_vserver index 1f8ea7c..14b5613 100644 --- a/checks/netscaler_vserver +++ b/checks/netscaler_vserver @@ -101,8 +101,8 @@ def check_netscaler_vserver(item, _no_params, info): health_state = 1 yield health_state, "Health at: %s%%" % health_perc, [("health_perc", health_perc, None, None, 0, 100)] - yield 0, "Type: %s" % netscaler_vserver_entitytypes.get(svr_entitytype , "unknown") - yield 0, "Protocol: %s" % netscaler_vserver_types.get(svr_type, "serviceUnknown") + yield 0, "Type: %s" % netscaler_vserver_entitytypes.get(svr_entitytype , "unknown (%s)" % svr_entitytype) + yield 0, "Protocol: %s" % netscaler_vserver_types.get(svr_type, "serviceUnknown (%s)" % svr_type) yield 0, "Socket: %s:%s" % (ip, port) check_info["netscaler_vserver"] = {