[checkmk-commits] [tribe29/checkmk] 32230c: Units: Introduce optional field for conversion

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 32230c50d1f28c84f440745f16237b0a51496a09 https://github.com/tribe29/checkmk/commit/32230c50d1f28c84f440745f16237b0a5… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/unit.py M cmk/gui/type_defs.py Log Message: ----------- Units: Introduce optional field for conversion Since converting when doing the actual rendering is too late, we instead need a function to convert the actual data points. Also remove the current conversion mechanism for the temperature unit and add the new field instead. As of this commit, the conversion of the temperature unit is temporarily broken, until we apply the conversion to the various places where data is retrieved from livestatus. CMK-12958 Change-Id: Ie1c67d8c9064e47754ec739ba46ebd5c7aafb9f9 Commit: 99e0ed47c1d1bcd75477a59f0ec3f7efac819ae5 https://github.com/tribe29/checkmk/commit/99e0ed47c1d1bcd75477a59f0ec3f7efa… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/utils/livestatus_helpers/testing.py Log Message: ----------- livestatus mocking: Add option to expect query for a single site This will be needed in the next commit for testing the conversion of queries RRD data according to the graph unit. CMK-12958 Change-Id: I657421bb6198fa45615fdccced4bfa135ae687eb Commit: 5a86a9ca00382b7ba2ad796d9550c89805a26c9c https://github.com/tribe29/checkmk/commit/5a86a9ca00382b7ba2ad796d9550c8980… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/utils/prediction.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py M tests/unit/cmk/utils/test_prediction_commons.py Log Message: ----------- Take unit conversions into account when fetching RRD data for graphs CMK-12958 Change-Id: Ie1003a7028cc90d6aef58cfa117f65986203eccf Commit: 0b6b3afe6da2e989f9c915b0e8c8af067807172f https://github.com/tribe29/checkmk/commit/0b6b3afe6da2e989f9c915b0e8c8af067… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Take unit conversions into account when merging multiple RRD columns This functionality is used in some dashlets and painters after fetching the data from livestatus. CMK-12958 Change-Id: If58351e2c2c69aa1b44b168708764023db2637c9 Commit: ad848e1ab2d79dbd5e4768ad897db33c87317f60 https://github.com/tribe29/checkmk/commit/ad848e1ab2d79dbd5e4768ad897db33c8… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/type_defs.py Log Message: ----------- Historical & forecast metric painters: Simplify rendering The rendering was unnecessarily complicated: After computing the final value to be rendered, including metric translations and unit conversions, this value was transformed into a perfomance data string. This string was subsequently parsed to extract the numerical value. Not only is this unnecessary, it would also soon lead to applying unit conversions twice: Once after fetching the historical data and once after parsing the artificially created performance data string. CMK-12958 Change-Id: I578a5427924dc71228795c4410b007e3c6df5d51 Commit: 296ade93203292bc493acd5169033410c8564fd2 https://github.com/tribe29/checkmk/commit/296ade93203292bc493acd5169033410c… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py Log Message: ----------- Take unit conversions into account when translating parsed perf data This applies to perfometers, graph legends, some single-metric dashlets and some views. CMK-12958 Change-Id: Ic740407583a225230406fdabc3099cc81486e5f5 Commit: ad4ca62a9c3fdd4abf8d1a7f4d36f3ddfbaeb34e https://github.com/tribe29/checkmk/commit/ad4ca62a9c3fdd4abf8d1a7f4d36f3ddf… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/metrics.py Log Message: ----------- Take unit conversions into account when rendering perfometer labels We offer the option to put a constant number as a label. In this (probably never occuring) case, we should convert. CMK-12958 Change-Id: I5604dda4b976b2fcc45ddb66555682e05923712f Commit: 3a4010f3246417bc1235f495939b14d49ea16e95 https://github.com/tribe29/checkmk/commit/3a4010f3246417bc1235f495939b14d49… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/metrics.py M tests/unit/cmk/gui/test_metrics.py Log Message: ----------- Take unit conversions into account when rendering linear perfometers CMK-12958 Change-Id: I174027bbdf611710d122ee3b8be6939f5a6f48a1 Commit: 72902541d391858403497d60bfe51e0cbbf02e02 https://github.com/tribe29/checkmk/commit/72902541d391858403497d60bfe51e0cb… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/metrics.py M tests/unit/cmk/gui/test_metrics.py Log Message: ----------- Take unit conversions into account when rendering logarithm. perfometers CMK-12958 Change-Id: I7c22ac544043895610c57119daafa7d1e84ab232 Commit: 44fb161199c0b4251c514466b40ef6727122c525 https://github.com/tribe29/checkmk/commit/44fb161199c0b4251c514466b40ef6727… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M Pipfile M Pipfile.lock M tests/integration/omd/test_python.py Log Message: ----------- Revert "Updated a few package dependencies." The package builds had extremely strange problems with that. This reverts commit 7d98d04ef022e291aa12bed09318b1c0de97df43. Commit: 77a5075818a60e85fa4d16d51674ffda28ff3c3c https://github.com/tribe29/checkmk/commit/77a5075818a60e85fa4d16d51674ffda2… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M tests/testlib/site.py Log Message: ----------- Disable helgrind (CMC tooling) in tests The current warnings are all related to one of - livestatus - move/memmove - thread notifications helgrind seems to be unfamiliar with the latest two very C++-heavy features. After thorough investigation, they appear to be false positives. livestatus is known to *not* be thread safe. See Also: https://github.com/CppMicroServices/CppMicroServices/issues/441 CMK-12511 Change-Id: Idab4e60f0615ef51da7e5de1342c9ee0ce723e34 Compare: https://github.com/tribe29/checkmk/compare/c7914d614d5a...77a5075818a6