[checkmk-commits] [tribe29/checkmk] c6fe41: agent parser: Extract helper functions

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c6fe41f28ab5950aa6a59075b30321991c5291af https://github.com/tribe29/checkmk/commit/c6fe41f28ab5950aa6a59075b30321991… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-01 (Tue, 01 Dec 2020) Changed paths: M cmk/base/checkers/agent.py Log Message: ----------- agent parser: Extract helper functions This improves readability and makes the state machine slightly more visible. CMK-5004 Change-Id: I31cd98b8cade9c00ade391a223114813f9fb67fe Commit: b6446c15d6612f09d884315a662090558c6adfd4 https://github.com/tribe29/checkmk/commit/b6446c15d6612f09d884315a662090558… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-01 (Tue, 01 Dec 2020) Changed paths: M tests/unit/cmk/base/checkers/test_agent.py Log Message: ----------- agent parser: Test a couple more edge cases CMK-5004 Change-Id: I86b74d4a882e66b06ae536e5ff4e68db4a2ec571 Commit: cf78411568d6fba4979f8f69c9649ec2c1e274d4 https://github.com/tribe29/checkmk/commit/cf78411568d6fba4979f8f69c9649ec2c… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-01 (Tue, 01 Dec 2020) Changed paths: M cmk/base/checkers/agent.py Log Message: ----------- agent parser: Remove obsolete type: ignore CMK-5004 Change-Id: I4791fbf9e7dd81284b0cd8d1cf5ce7b8e34bdca8 Commit: 0919975848210cf1f9aede25e0a21ec0e909de8b https://github.com/tribe29/checkmk/commit/0919975848210cf1f9aede25e0a21ec0e… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-01 (Tue, 01 Dec 2020) Changed paths: M cmk/base/checkers/agent.py Log Message: ----------- agent parser: Remove one unnecessary tmp variable We remove the tmp: `section_content` and move the logic to `section_header`. Indeed, the parser "knows" it is parsing a host section because it could obtain a host section header. That there may be a section content is but a side effect. The improved logic advantageously replaces the logic of the state machine from crash to noop. CMK-5004 Change-Id: Ifd0d18b473820b97c8aa02d4406572216159b39b Commit: 1420527eb40219fafdaa05f96c1d018573052b3c https://github.com/tribe29/checkmk/commit/1420527eb40219fafdaa05f96c1d01857… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-01 (Tue, 01 Dec 2020) Changed paths: M cmk/base/checkers/agent.py Log Message: ----------- agent parser: Extract actual host section parser Interestingly, most of the code was *not* parsing the line. The non-parsing part is now in `__init__()` whereas the parser is in a `parse(line: bytes) -> None` method. CMK-5004 Change-Id: I7ac878e34ebaf0a443092c20747cdebbe8fd67d8 Commit: 97b8063c1b3706536e2a0b298bb033afe752d204 https://github.com/tribe29/checkmk/commit/97b8063c1b3706536e2a0b298bb033afe… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-01 (Tue, 01 Dec 2020) Changed paths: M cmk/base/checkers/agent.py Log Message: ----------- agent parser: better typing with NOOPState CMK-5004 Change-Id: I21187bbf36ffb45ca3d8964110303e69a6432ac3 Commit: f3fe4b62b503f5e30c7c8bed93bfc75b33c63752 https://github.com/tribe29/checkmk/commit/f3fe4b62b503f5e30c7c8bed93bfc75b3… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-01 (Tue, 01 Dec 2020) Changed paths: M cmk/base/checkers/agent.py M tests/unit/cmk/base/checkers/test_agent.py Log Message: ----------- Let host section parser handle full header CMK-5004 Change-Id: I1202dc84887ae869f295621963e591e8ce1e31c3 Commit: 50af1e4c474150e8a223ef19fc24e34156093408 https://github.com/tribe29/checkmk/commit/50af1e4c474150e8a223ef19fc24e3415… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-01 (Tue, 01 Dec 2020) Changed paths: M cmk/base/checkers/agent.py M tests/unit/cmk/base/checkers/test_agent.py Log Message: ----------- agent parser: Complete FSM with state PiggybackSectionParser CMK-5004 Change-Id: Ifc3ab73ddb14baf20cf57bb9c0545d6ab7d16b81 Commit: 417abc300f21a40ff922f6f63e2017785ef5963c https://github.com/tribe29/checkmk/commit/417abc300f21a40ff922f6f63e2017785… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-01 (Tue, 01 Dec 2020) Changed paths: M cmk/base/checkers/agent.py Log Message: ----------- Remove extra call to `time.time()` `cached_at` already is `time.time()` but called *before* we start parsing. Calling it again *in* the parser does not really bring anything. CMK-6516 Change-Id: Ifd4f2b34c44cf4d15b7bd98668d0fbb2c36384e5 Compare: https://github.com/tribe29/checkmk/compare/d197d2d135fc...417abc300f21