29 Aug
2023
29 Aug
'23
7:43 a.m.
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: d6b3bdb034302c4866e0e523af24291f2e0601dc
https://github.com/Checkmk/checkmk/commit/d6b3bdb034302c4866e0e523af24291f2…
Author: Gav <gavin.mcguigan(a)checkmk.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
A .werks/15968
M cmk/gui/plugins/openapi/endpoints/host_config/__init__.py
M cmk/gui/plugins/openapi/endpoints/host_config/request_schemas.py
M tests/testlib/rest_api_client.py
M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py
Log Message:
-----------
15968 FIX host_config: update endpoint now only allows one of replace, update or delete
Previously when calling update host, you could pass any combination of
replace all attributes
update some attributes
delete some attributes
Some of these combinations didn't make much sense and could lead to
errors. This werk simplifies this by only allowing one of the options
when calling update host or bulk update host.
For update_host, previously you could to the following
C+:
{
"attributes": {"ipaddress": "192.168.9.123"},
"update_attributes" {"ipaddress": "192.168.0.123"},
"remove_attributes": ["tag_foobar],
}
C-:
This werk modifies this behaviour by forcing the client to select only
one action.
C+:
{
"attributes": {"ipaddress": "192.168.9.123"},
}
C-:
OR
C+:
{
"update_attributes": {"ipaddress": "192.168.9.124"},
}
C-:
OR
C+:
"remove_attributes": ["tag_foobar"],
C-:
CMK-14148
Change-Id: Ib1396985b830c6b4aefca5a351f1e6d19356fcdc
Commit: 9e4b9534005283c41c5823faf37b9e043b00c613
https://github.com/Checkmk/checkmk/commit/9e4b9534005283c41c5823faf37b9e043…
Author: Gav <gavin.mcguigan(a)checkmk.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M cmk/gui/plugins/openapi/endpoints/host_config/__init__.py
Log Message:
-----------
host_config: code cleanup
Remove _verify_hostname() func and it's callers. The hostname is
already verified in the schemas for the endpoints modified.
Change-Id: I66014463caa5cb84d12690f290c187ccdbea7069
Commit: 481b8d4bfee6d624710726fc9070bc9cdea00d17
https://github.com/Checkmk/checkmk/commit/481b8d4bfee6d624710726fc9070bc9cd…
Author: Gav <gavin.mcguigan(a)checkmk.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M tests/testlib/rest_api_client.py
M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py
Log Message:
-----------
host_config: update remaining tests to use the HostConfig client
Change-Id: I7b64f7bf3a44886bdb3163bc3fb3b6fd0d108faa
Commit: 67463cb0d41e7f105131b1023adb851a9695a845
https://github.com/Checkmk/checkmk/commit/67463cb0d41e7f105131b1023adb851a9…
Author: Matteo Stifano <matteo.stifano(a)checkmk.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M tests/update/conftest.py
Log Message:
-----------
Add pytest flag to select only the latest base-version
A new flag is here introduced for the update-test.
Such flag is helpful for debugging purposes to easily avoid the test to
select all base-versions.
Change-Id: I60c485ccf07680633922f093960321949542ebc9
Commit: 5a9b8bac0e43e1bfd920305f99973daac227a6a1
https://github.com/Checkmk/checkmk/commit/5a9b8bac0e43e1bfd920305f99973daac…
Author: Matteo Stifano <matteo.stifano(a)checkmk.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M tests/update/conftest.py
M tests/update/test_update.py
Log Message:
-----------
Use REST-API to retrieve services in update-test
The web-API is here replaced by REST-API in update-test.
Logging functions are also refactored.
Change-Id: If36dcbc9443415fae077a9e3501d5471f805a7ed
Commit: 0b3d7320d5cb926745c6d193e9e6823e53cd9ae0
https://github.com/Checkmk/checkmk/commit/0b3d7320d5cb926745c6d193e9e6823e5…
Author: Matteo Stifano <matteo.stifano(a)checkmk.com>
Date: 2023-08-29 (Tue, 29 Aug 2023)
Changed paths:
M tests/update/conftest.py
Log Message:
-----------
Remove unused functions in conftest module
Change-Id: I81b2ec83b700b5f94f04d78250b0ae8e6bf7ed37
Compare: https://github.com/Checkmk/checkmk/compare/17b73ca72e6b...0b3d7320d5cb