[checkmk-commits] 5526 FIX check_dns: Do not pass off the host' s IP address as a default DNS server address

Module: check_mk Branch: master Commit: c28b034aaef75843df25d886dc0344b9c847559d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c28b034aaef758… Author: Konstantin Büttner <kb(a)mathias-kettner.de> Date: Tue Dec 12 13:02:07 2017 +0100 5526 FIX check_dns: Do not pass off the host's IP address as a default DNS server address Previously, in case of the DNS server address not being specified, Check_MK would fill it in with the host's IP address, causing the check to time out. This has been fixed. Thanks to Björn Müller for the patch! Change-Id: I307bf8f0550fcc2305cc81884081665b516f5082 --- .werks/5526 | 14 ++++++++++++++ checks/check_dns | 2 -- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/.werks/5526 b/.werks/5526 new file mode 100644 index 0000000..515dcbf --- /dev/null +++ b/.werks/5526 @@ -0,0 +1,14 @@ +Title: check_dns: Do not pass off the host's IP address as a default DNS server address +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i2 +Date: 1513079892 + +Previously, in case of the DNS server address not being specified, Check_MK would +fill it in with the host's IP address, causing the check to time out. This has been fixed. + +Thanks to Björn Müller for the patch! diff --git a/checks/check_dns b/checks/check_dns index 743636f..2f5bbd2 100644 --- a/checks/check_dns +++ b/checks/check_dns @@ -31,8 +31,6 @@ def check_dns_arguments(params): if "server" in settings: if settings["server"] != None: args += ' -s %s' % quote_shell_string(settings["server"]) - else: - args += " -s '$HOSTADDRESS$'" if "expected_address" in settings: # Convert from old (str) to new (list of strings)